Skip to content

Commit d17b632

Browse files
committed
Quick Fix (NestJS Link Removal)
- Removed the NestJS link since it points to a private repo and replaced it with a summary of my contributions to the NestJS boilerplate and some relevant info about the repo
1 parent 2fbb2f1 commit d17b632

2 files changed

Lines changed: 9 additions & 2 deletions

File tree

quartz/components/ExperienceItem.tsx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,10 @@ const isLink = (data: unknown): data is Link => {
6060
return isObject(data) && data.url !== undefined;
6161
}
6262

63+
const isTextOnly = (data: unknown): data is { title: string } => {
64+
return isObject(data) && data.url === undefined;
65+
}
66+
6367
const renderPHAndGitHubLinks = (productHuntLaunchURL: string | undefined, githubURL: string | undefined) => {
6468
return (productHuntLaunchURL || githubURL) &&
6569
<p><span>Links: </span>
@@ -120,6 +124,8 @@ export default ((userOpts?: Options) => {
120124
{item.subItems.map((subItem) => {
121125
if (isLink(subItem)) {
122126
return <li><a href={subItem.url} target="_target">{ subItem.title }</a></li>
127+
} else if (isTextOnly(subItem)) {
128+
return <li>{ subItem.title }</li>
123129
} else {
124130
return <li>{subItem}</li>
125131
}

quartz/static/dev-experience/experience-history.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,12 +84,13 @@ export const devExperienceItems: ExperienceItem[] = [
8484
],
8585
responsibilitiesAndWins: [
8686
{ title: "Served as a full-stack developer on the Internal Tooling Team. We developed and maintained frontend and backend boilerplates for the developers at Bitwise Technology Services. For reference, Bitwise Technology Services was originally called Shift3." },
87+
{ title: "Enhanced the NestJS boilerplate with agent change tracking, improved error handling, and environment variable validation" },
8788
{ prefixText: "Frontend Contributions:", title: "React Boilerplate", url: "https://github.com/Shift3/boilerplate-client-react/pulls?page=1&q=is%3Apr+is%3Aclosed+author%3Ajoshwingreene" },
8889
{
8990
title: "Backend Contributions:",
9091
subItems: [
91-
{ title: "NestJS Boilerplate", url: "https://github.com/Shift3/boilerplate-server-node/pulls?q=is%3Apr+is%3Aclosed+author%3Ajoshwingreene" },
92-
{ title: "Django Boilerplate", url: "https://github.com/Shift3/dj-starter/pulls?q=is%3Apr+is%3Aclosed+author%3Ajoshwingreene" }
92+
{ title: "Django Boilerplate", url: "https://github.com/Shift3/dj-starter/pulls?q=is%3Apr+is%3Aclosed+author%3Ajoshwingreene" },
93+
{ title: "NestJS Boilerplate (3 Pull Requests)(Private Repo)" },
9394
]
9495
}
9596

0 commit comments

Comments
 (0)