netty: code cleanup/enhancements

Author: jknack

modules/jooby-netty/src/main/java/io/jooby/internal/netty/NettyHandler.java

@@ -65,6 +65,7 @@ public void handlerAdded(ChannelHandlerContext ctx) throws Exception {
   public void channelRead(ChannelHandlerContext ctx, Object msg) {
     if (isHttpRequest(msg)) {
       this.read = true;
+      this.chunkSize = 0;
       var req = (HttpRequest) msg;
       var path = pathOnly(req.uri());
       var app = contextSelector.select(path);
@@ -140,8 +141,14 @@ public void writeChunks(Object header, Object body, Object last, ChannelPromise
       channelContext.write(header, voidPromise);
       // Body
       channelContext.write(body, voidPromise);
+
       // Finish
-      channelContext.writeAndFlush(last, promise);
+      if (this.read) {
+        this.flush = true;
+        channelContext.write(last, promise); // Defer flush
+      } else {
+        channelContext.writeAndFlush(last, promise); // Immediate flush
+      }
     } else {
       this.channelContext.executor().execute(() -> writeChunks(header, body, last, promise));
     }
@@ -159,8 +166,14 @@ public void writeChunks(Object header, Object body, ChannelPromise promise) {
     if (this.channelContext.executor().inEventLoop()) {
       // Headers
       channelContext.write(header, channelContext.voidPromise());
+
       // Body + Last
-      channelContext.writeAndFlush(body, promise);
+      if (this.read) {
+        this.flush = true;
+        channelContext.write(body, promise); // Defer flush
+      } else {
+        channelContext.writeAndFlush(body, promise); // Immediate flush
+      }
     } else {
       this.channelContext.executor().execute(() -> writeChunks(header, body, promise));
     }
@@ -217,7 +230,13 @@ public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) {
         }
       }
     } finally {
-      ctx.close();
+      try {
+        if (context != null) {
+          resetDecoderState(context, true); // Force decoder cleanup on failure
+        }
+      } finally {
+        ctx.close();
+      }
     }
   }