build: always run test in random port(0)

Author: jknack

.github/workflows/full-build.yml

@@ -26,8 +26,6 @@ jobs:
       - name: Build
         run: mvn -B package -P gradlePlugin
         env:
-          BUILD_PORT: 0
-          BUILD_SECURE_PORT: 0
           BUILD_LOG_LEVEL: 'ERROR'
       - name: Tests
         uses: mikepenz/action-junit-report@v5

.github/workflows/quick-build.yml

@@ -27,8 +27,6 @@ jobs:
       - name: Install
         run: mvn install -DskipTests -q -B
         env:
-          BUILD_PORT: 0
-          BUILD_SECURE_PORT: 0
           BUILD_LOG_LEVEL: 'ERROR'
       - name: Build
         run: mvn package

jooby/src/main/java/io/jooby/ServerOptions.java

@@ -8,8 +8,6 @@
 import static java.util.Spliterators.spliteratorUnknownSize;
 import static java.util.stream.StreamSupport.stream;
 
-import java.io.IOException;
-import java.net.ServerSocket;
 import java.security.Security;
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -271,7 +269,7 @@ public int getPort() {
    * @return This options.
    */
   public @NonNull ServerOptions setPort(int port) {
-    this.port = port == 0 ? randomPort() : port;
+    this.port = Math.max(0, port);
     return this;
   }
 
@@ -303,7 +301,7 @@ public boolean isSSLEnabled() {
     if (securePort == null) {
       this.securePort = null;
     } else {
-      this.securePort = securePort == 0 ? randomPort() : securePort;
+      this.securePort = Math.max(0, securePort);
     }
     return this;
   }
@@ -657,13 +655,4 @@ public ServerOptions setExpectContinue(@Nullable Boolean expectContinue) {
     }
     return null;
   }
-
-  private static int randomPort() {
-    try (ServerSocket socket = new ServerSocket(0)) {
-      socket.setReuseAddress(true);
-      return socket.getLocalPort();
-    } catch (IOException x) {
-      throw SneakyThrows.propagate(x);
-    }
-  }
 }

modules/jooby-jetty/src/main/java/io/jooby/jetty/JettyServer.java

@@ -163,19 +163,21 @@ public io.jooby.Server start(@NonNull Jooby... application) {
         connectionFactories.addAll(http2.configure(httpConf));
       }
 
+      ServerConnector httpConector = null;
       if (!options.isHttpsOnly()) {
-        var http =
+        httpConector =
             new ServerConnector(
                 server,
                 acceptors,
                 selectors,
                 connectionFactories.toArray(new ConnectionFactory[0]));
-        http.setPort(options.getPort());
-        http.setHost(options.getHost());
+        httpConector.setPort(options.getPort());
+        httpConector.setHost(options.getHost());
 
-        server.addConnector(http);
+        server.addConnector(httpConector);
       }
 
+      ServerConnector secureConnector = null;
       if (options.isSSLEnabled()) {
         var classLoader = applications.get(0).getClassLoader();
         var sslContextFactory = new SslContextFactory.Server();
@@ -208,7 +210,7 @@ public io.jooby.Server start(@NonNull Jooby... application) {
         }
         secureConnectionFactories.add(new HttpConnectionFactory(httpsConf));
 
-        var secureConnector =
+        secureConnector =
             new ServerConnector(
                 server,
                 acceptors,
@@ -272,6 +274,15 @@ public io.jooby.Server start(@NonNull Jooby... application) {
       server.setHandler(context);
       server.start();
 
+      // --- EXTRACT OS-ASSIGNED PORTS ---
+      if (httpConector != null) {
+        options.setPort(httpConector.getLocalPort());
+      }
+      if (secureConnector != null) {
+        options.setSecurePort(secureConnector.getLocalPort());
+      }
+      // ---------------------------------
+
       fireReady(applications);
     } catch (Exception x) {
       if (io.jooby.Server.isAddressInUse(x.getCause())) {

modules/jooby-netty/src/main/java/io/jooby/netty/NettyServer.java

@@ -166,7 +166,15 @@ public Server start(@NonNull Jooby... application) {
         var http =
             newBootstrap(
                 allocator, transport, newPipeline(options, null, http2, grpcProcessor), eventLoop);
-        http.bind(options.getHost(), options.getPort()).get();
+
+        var httpFuture = http.bind(options.getHost(), options.getPort());
+        if (options.getPort() == 0) {
+          httpFuture.get(); // Wait for bind to complete
+          java.net.SocketAddress address = httpFuture.channel().localAddress();
+          if (address instanceof java.net.InetSocketAddress) {
+            options.setPort(((java.net.InetSocketAddress) address).getPort());
+          }
+        }
       }
 
       if (options.isSSLEnabled()) {
@@ -184,7 +192,14 @@ public Server start(@NonNull Jooby... application) {
                 newPipeline(options, sslContext, http2, grpcProcessor),
                 eventLoop);
         portInUse = options.getSecurePort();
-        https.bind(options.getHost(), portInUse).get();
+        var httpsFuture = https.bind(options.getHost(), portInUse);
+        if (portInUse == 0) {
+          httpsFuture.get();
+          var address = httpsFuture.channel().localAddress();
+          if (address instanceof java.net.InetSocketAddress inetSocketAddress) {
+            options.setSecurePort(inetSocketAddress.getPort());
+          }
+        }
       } else if (options.isHttpsOnly()) {
         throw new StartupException("Server configured for httpsOnly, but ssl options not set");
       }

modules/jooby-undertow/src/main/java/io/jooby/undertow/UndertowServer.java

@@ -178,18 +178,35 @@ public Server start(@NonNull Jooby... application) {
             .ifPresent(
                 clientAuth -> builder.setSocketOption(Options.SSL_CLIENT_AUTH_MODE, clientAuth));
       } else if (options.isHttpsOnly()) {
-        throw new StartupException("Server configured for httpsOnly, but ssl options not set");
+        throw new StartupException("Server configured for httpsOnly, but ssl options are not set");
       }
       fireStart(applications, worker);
       server = builder.build();
       server.start();
 
+      // --- EXTRACT OS-ASSIGNED PORTS ---
+      for (var info : server.getListenerInfo()) {
+        var address = info.getAddress();
+        if (address instanceof java.net.InetSocketAddress inetSocketAddress) {
+          int actualPort = inetSocketAddress.getPort();
+
+          if ("https".equalsIgnoreCase(info.getProtcol())) {
+            options.setSecurePort(actualPort);
+          } else {
+            options.setPort(actualPort);
+          }
+        }
+      }
+      // ---------------------------------
+
       fireReady(applications);
 
       return this;
     } catch (Exception x) {
       Throwable sourceException = x;
       Throwable cause = Optional.ofNullable(x.getCause()).orElse(x);
+      cause.printStackTrace();
+      System.out.println(options.toString());
       if (Server.isAddressInUse(cause)) {
         sourceException = new BindException("Address already in use: " + portInUse);
       }

tests/src/test/java/io/jooby/i3783/Issue3783.java

@@ -13,7 +13,6 @@
 import okhttp3.FormBody;
 
 public class Issue3783 {
-
   @ServerTest
   public void shouldAllowToSetMaxFormFields(ServerTestRunner runner) {
     runner

tests/src/test/java/io/jooby/junit/ServerTestRunner.java

@@ -103,18 +103,19 @@ public void ready(SneakyThrows.Consumer2<WebClient, WebClient> onReady) {
       // HTTP/2 is off while testing unless explicit set
       ServerOptions options = server.getOptions();
       options.setHttp2(Optional.ofNullable(options.isHttp2()).orElse(Boolean.FALSE));
-      options.setPort(Integer.parseInt(System.getenv().getOrDefault("BUILD_PORT", "9999")));
-      this.allocatedPort = options.getPort();
-      WebClient https;
+      options.setPort(0);
       if (options.isSSLEnabled()) {
-        options.setSecurePort(
-            Integer.parseInt(System.getenv().getOrDefault("BUILD_SECURE_PORT", "9443")));
-        https = new WebClient("https", options.getSecurePort(), followRedirects);
-      } else {
-        https = null;
+        options.setSecurePort(0);
       }
+      WebClient https = null;
       try {
         MutedServer.mute(server).start(app);
+        this.allocatedPort = options.getPort();
+        if (options.isSSLEnabled()) {
+          https = new WebClient("https", options.getSecurePort(), followRedirects);
+        } else {
+          https = null;
+        }
         if (options.isHttpsOnly()) {
           onReady.accept(null, https);
         } else {