io.jooby.Value to method should be marked as nullable #2300

Author: jknack

jooby/src/main/java/io/jooby/Context.java

@@ -119,7 +119,7 @@ public interface Context extends Registry {
    * @param <T> Generic type.
    * @return Converted value.
    */
-  @Nullable <T> T convert(@Nonnull ValueNode value, @Nonnull Class<T> type);
+  @Nonnull <T> T convert(@Nonnull ValueNode value, @Nonnull Class<T> type);
 
   /*
    * **********************************************************************************************

jooby/src/main/java/io/jooby/DefaultContext.java

@@ -371,7 +371,7 @@ public interface DefaultContext extends Context {
     return body().to(type);
   }
 
-  @Override default @Nullable <T> T convert(ValueNode value, Class<T> type) {
+  @Override default @Nonnull <T> T convert(@Nonnull ValueNode value, @Nonnull Class<T> type) {
     T result = ValueConverters.convert(value, type, getRouter());
     if (result == null) {
       throw new TypeMismatchException(value.name(), type);

jooby/src/main/java/io/jooby/ForwardingContext.java

@@ -340,7 +340,7 @@ public ForwardingContext(@Nonnull Context context) {
     return ctx.body(type);
   }
 
-  @Nullable @Override public <T> T convert(ValueNode value, Class<T> type) {
+  @Nonnull @Override public <T> T convert(@Nonnull ValueNode value, @Nonnull Class<T> type) {
     return ctx.convert(value, type);
   }
 

modules/jooby-test/src/main/java/io/jooby/MockContext.java

@@ -711,7 +711,7 @@ public MockContext sendError(@Nonnull Throwable cause, @Nonnull StatusCode code)
     return this;
   }
 
-  @Nullable @Override public <T> T convert(ValueNode value, Class<T> type) {
+  @Nonnull @Override public <T> T convert(@Nonnull ValueNode value, @Nonnull Class<T> type) {
     return DefaultContext.super.convert(value, type);
   }