Skip to content

Commit 53b69b7

Browse files
Test Userclaude
andcommitted
fix: resolve lint errors (import sort, nested ternary)
- Sort imports alphabetically in config.ts (DEFAULT_MERGER) - Extract nested ternary in review.ts to separate variable Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 4255666 commit 53b69b7

2 files changed

Lines changed: 17 additions & 10 deletions

File tree

packages/cli/src/commands/review.ts

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -166,8 +166,7 @@ export function postReadyForHumanReviewComment(
166166
finalScore: number | undefined,
167167
cwd: string,
168168
): void {
169-
const scoreNote =
170-
finalScore !== undefined ? ` (score: ${finalScore}/100)` : '';
169+
const scoreNote = finalScore !== undefined ? ` (score: ${finalScore}/100)` : '';
171170
const body =
172171
`## ✅ Ready for Human Review\n\n` +
173172
`Night Watch has reviewed this PR${scoreNote} and found no issues requiring automated fixes.\n\n` +
@@ -520,12 +519,15 @@ export function reviewCommand(program: Command): void {
520519
const reviewedPrNumbers = parseReviewedPrNumbers(scriptResult?.data.prs);
521520
const noChangesPrNumbers = parseReviewedPrNumbers(scriptResult?.data.no_changes_prs);
522521
const fallbackPrNumber = fallbackPrDetails?.number;
522+
// Resolve primary PR numbers: prefer reviewed PRs, fall back to fallback PR
523+
const primaryPrNumbers: number[] = [];
524+
if (reviewedPrNumbers.length > 0) {
525+
primaryPrNumbers.push(...reviewedPrNumbers);
526+
} else if (fallbackPrNumber !== undefined) {
527+
primaryPrNumbers.push(fallbackPrNumber);
528+
}
523529
const notificationTargets = buildReviewNotificationTargets(
524-
reviewedPrNumbers.length > 0
525-
? reviewedPrNumbers
526-
: fallbackPrNumber !== undefined
527-
? [fallbackPrNumber]
528-
: [],
530+
primaryPrNumbers,
529531
noChangesPrNumbers,
530532
legacyNoChangesNeeded,
531533
);
@@ -567,7 +569,10 @@ export function reviewCommand(program: Command): void {
567569
event: reviewEvent,
568570
projectName: path.basename(projectDir),
569571
exitCode,
570-
provider: formatProviderDisplay(envVars.NW_PROVIDER_CMD, envVars.NW_PROVIDER_LABEL),
572+
provider: formatProviderDisplay(
573+
envVars.NW_PROVIDER_CMD,
574+
envVars.NW_PROVIDER_LABEL,
575+
),
571576
prUrl: prDetails?.url,
572577
prTitle: prDetails?.title,
573578
prBody: prDetails?.body,

packages/core/src/config.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import {
2121
DEFAULT_ANALYTICS,
2222
DEFAULT_AUDIT,
2323
DEFAULT_AUTO_MERGE,
24-
DEFAULT_MERGER,
2524
DEFAULT_AUTO_MERGE_METHOD,
2625
DEFAULT_BOARD_PROVIDER,
2726
DEFAULT_BRANCH_PATTERNS,
@@ -36,6 +35,7 @@ import {
3635
DEFAULT_MAX_LOG_SIZE,
3736
DEFAULT_MAX_RETRIES,
3837
DEFAULT_MAX_RUNTIME,
38+
DEFAULT_MERGER,
3939
DEFAULT_MIN_REVIEW_SCORE,
4040
DEFAULT_NOTIFICATIONS,
4141
DEFAULT_PRD_DIR,
@@ -220,7 +220,9 @@ function mergeConfigs(
220220
merged.merger = {
221221
...merged.merger,
222222
enabled: true,
223-
mergeMethod: (merged as unknown as Record<string, unknown>).autoMergeMethod as IMergerConfig['mergeMethod'] ?? 'squash',
223+
mergeMethod:
224+
((merged as unknown as Record<string, unknown>)
225+
.autoMergeMethod as IMergerConfig['mergeMethod']) ?? 'squash',
224226
};
225227
}
226228

0 commit comments

Comments
 (0)