Missing wrapper for `xPortIsInsideInterrupt()`

[lukasnee]

Even though xPortIsInsideInterrupt() is not available on all ports of FreeRTOS, it would be very useful to have it wrapped. I personally develop on STM32 platform and use this function sometimes. AFAIK, all GCC ARM FreeRTOS ports have xPortIsInsideInterrupt() implementation.

However, I'm not sure where exactly the wrapper should be since the xPortIsInsideInterrupt() implementation lives on the portable/ side.

Nice library by the way! I've just started using it.

[jonenz]

This is something I would probably put in the Kernel or a Kernel::Portable namespace, but there are a few problems I see at first glance with some of the portable functions.

1. I'd like to keep this wrapper library independent of the port selection/configuration for the RTOS. I don't want to duplicate any port configurations or implementations.
2. There doesn't seem to be a complete or consistent interface for all of the possible functions that a port file can provide. The file portable/template/portmacro.h provides the required interface, but not all of the potential functions.
3. Some of the potential functions (xPortIsInsideInterrupt included) don't have macro wrappers, so they can't be tested for existence using the preprocessor.

If the port interface were more defined in the way the rest of the library interface is, I would definitely add it to the pattern. As a workaround for now, I would just create a header file with namespace that matches the pattern for your project. Something like:

namespace FreeRTOS {
namespace Portable {
  inline static bool isInsideInterrupt() {
    return (xPortIsInsideInterrupt() == pdTRUE);
  }
} // namespace Portable
} // namespace FreeRTOS

[lukasnee]

Yeah, I must agree with your concerns. Thanks for a thorough response :) And thanks for the effort on the project, so far I find it really nice and well made. I think you have a good vision on keeping the wrapper very thin.