From b5d3c2c757710d3b79769272190cba5d7f7c3984 Mon Sep 17 00:00:00 2001 From: Jonathan Algar <93204286+jonathanalgar@users.noreply.github.com> Date: Sun, 23 Feb 2025 00:08:04 +0000 Subject: [PATCH 1/2] change --- src/CustomCode-Analyzer/Analyzer.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/CustomCode-Analyzer/Analyzer.cs b/src/CustomCode-Analyzer/Analyzer.cs index 9e3ff44..3425649 100644 --- a/src/CustomCode-Analyzer/Analyzer.cs +++ b/src/CustomCode-Analyzer/Analyzer.cs @@ -887,8 +887,8 @@ ConcurrentDictionary candidateInputSizeLimitDiagnostics { foreach (var parameter in methodSymbol.Parameters) { - // Disallow reference-like (ref/out/in) parameters - if (parameter.RefKind is RefKind.Ref or RefKind.Out or RefKind.In) + // Disallow reference-like (ref/in) parameters + if (parameter.RefKind is RefKind.Ref or RefKind.In) { var paramSyntax = parameter.DeclaringSyntaxReferences.FirstOrDefault()?.GetSyntax() From fa6121691c753062fcaef1f8630f287970b8881b Mon Sep 17 00:00:00 2001 From: Jonathan Algar <93204286+jonathanalgar@users.noreply.github.com> Date: Sun, 23 Feb 2025 00:18:57 +0000 Subject: [PATCH 2/2] update tests --- tests/CustomCode-Analyzer.Tests/AnalyzerTests.cs | 8 -------- 1 file changed, 8 deletions(-) diff --git a/tests/CustomCode-Analyzer.Tests/AnalyzerTests.cs b/tests/CustomCode-Analyzer.Tests/AnalyzerTests.cs index 9036836..2639bea 100644 --- a/tests/CustomCode-Analyzer.Tests/AnalyzerTests.cs +++ b/tests/CustomCode-Analyzer.Tests/AnalyzerTests.cs @@ -1163,10 +1163,6 @@ public void ReadValue(in double number) { } .Diagnostic(DiagnosticIds.ParameterByReference) .WithSpan(5, 22, 5, 35) .WithArguments("value", "UpdateValue"), - CSharpAnalyzerVerifier - .Diagnostic(DiagnosticIds.ParameterByReference) - .WithSpan(6, 19, 6, 34) - .WithArguments("text", "GetValue"), CSharpAnalyzerVerifier .Diagnostic(DiagnosticIds.ParameterByReference) .WithSpan(7, 20, 7, 36) @@ -1213,10 +1209,6 @@ public void ReadValue(in double number) { } .Diagnostic(DiagnosticIds.ParameterByReference) .WithSpan(7, 26, 7, 39) .WithArguments("value", "UpdateValue"), - CSharpAnalyzerVerifier - .Diagnostic(DiagnosticIds.ParameterByReference) - .WithSpan(8, 23, 8, 38) - .WithArguments("text", "GetValue"), CSharpAnalyzerVerifier .Diagnostic(DiagnosticIds.ParameterByReference) .WithSpan(9, 24, 9, 40)