Skip to content

🐛 fix: react-native@0.68.2 always load main.jsbundle instead of thread bundle #158

@anasmassnaoui

Description

@anasmassnaoui

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-native-threads@0.0.19 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-threads/ios/ThreadManager.m b/node_modules/react-native-threads/ios/ThreadManager.m
index 3aa1bba..f3b22aa 100644
--- a/node_modules/react-native-threads/ios/ThreadManager.m
+++ b/node_modules/react-native-threads/ios/ThreadManager.m
@@ -19,8 +19,15 @@ @implementation ThreadManager
   }
 
   int threadId = abs(arc4random());
+    NSURL *threadURL = NULL;
+
+  // NSURL *threadURL = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:name fallbackResource:name];
+#if DEBUG
+    threadURL = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:name];
+#else
+    threadURL = [[NSBundle mainBundle] URLForResource:name withExtension:@"jsbundle"];
+#endif
 
-  NSURL *threadURL = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:name fallbackResource:name];
   NSLog(@"starting Thread %@", [threadURL absoluteString]);
 
 

This issue body was partially generated by patch-package.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions