Skip to content

Commit eccb039

Browse files
authored
php 8.4 support (#28)
* php 8.4 support * comment
1 parent 717ba51 commit eccb039

3 files changed

Lines changed: 4 additions & 3 deletions

File tree

.github/workflows/code_checks.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
stability: prefer-stable
2828
- php: '8.3'
2929
stability: prefer-stable
30-
- php: '8.4-rc'
30+
- php: '8.4'
3131
stability: prefer-stable
3232

3333
name: PHP ${{ matrix.php }} - ${{ matrix.symfony-version }} - ${{ matrix.stability }}

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,9 @@ SIEPHP comes with docker compose to ease development, to build dev docker contai
8585
docker compose up --build -d
8686
```
8787

88-
And once it is built, enter the php 8.2 or 8.3 container:
88+
And once it is built, enter the php 8.2, 8.3 or 8.4 container:
8989
```bash
90+
docker exec -it siephp-php82 bash
9091
docker exec -it siephp-php83 bash
9192
docker exec -it siephp-php84 bash
9293
```

docker/dockerfile-siephp-php84

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM php:8.4-rc
1+
FROM php:8.4
22
COPY --from=composer:latest /usr/bin/composer /usr/local/bin/composer
33

44
RUN apt-get update && apt-get install -y git curl nano zip

0 commit comments

Comments
 (0)