Fix JS Date --> Oracle Date conversion to use UTC methods.

Update unit test, since TIMESTAMPs do store time info.
Update README to explain how DATEs and TIMESTAMPs are handled

Author: johannish

README.md

@@ -154,13 +154,43 @@ if (!connection.isConnected()) {
 }
 ```
 
+### Dates
+For DATE and TIMESTAMP types, the driver uses the UTC methods from the Javascript Date object. This means the DATE
+value stored will match the value of `new Date().toISOString()` on your client machine.  Consider this example
+for a client machine in "GMT-0700":
 
-# Limitations
+Table schema:
 
-* Currently no support for column type "Timestamp With Timezone" (Issue #67)
-* Currently no native support for connection pooling (forthcoming; use generic-pool for now.)
-* Use getUTC... javascript functions when dealing with dates (See Github discussion on 44b872f)
+```sql
+CREATE TABLE date_test (mydate DATE)
+```
+
+Javascript code:
 
+```javascript
+...
+	var date = new Date(2013, 11, 24, 18, 0, 1);  // Client timezone dependent
+	console.log(date.toString());      // Tue Dec 24 2013 18:00:01 GMT-0700 (MST)
+	console.log(date.toISOString());   // 2013-12-25T01:00:01.000Z
+
+	connection.execute(
+		"INSERT INTO date_test (mydate) VALUES (:1) " +
+			"RETURNING mydate, to_char(mydate, 'YYYY-MM-DD HH24:MI:SS') INTO :2, :3",
+		[date, new oracle.OutParam(oracle.OCCIDATE), new oracle.OutParam(oracle.OCCISTRING)],
+		function(err, results) {
+			console.log(results.returnParam.toString());  // Tue Dec 24 2013 18:00:01 GMT-0700 (MST)
+			console.log(results.returnParam1);            // 2013-12-25 01:00:01
+		}
+	);
+...
+```
+
+# Limitations/Caveats
+
+* Currently no native support for connection pooling (forthcoming; use generic-pool for now.)
+* Currently no support for column type "Timestamp With Timezone" (Issue #67)
+* While the Oracle TIMESTAMP type provides fractional seconds up to 9 digits (nanoseconds), this will be rounded
+  to the nearest millisecond when converted to a Javascript date (a _data loss_).
 
 # Development
 * Clone the source repo

src/executeBaton.cpp

@@ -61,12 +61,13 @@ double CallDateMethod(v8::Local<v8::Date> date, const char* methodName) {
 }
 
 oracle::occi::Date* V8DateToOcciDate(oracle::occi::Environment* env, v8::Local<v8::Date> val) {
-  int year = CallDateMethod(val, "getFullYear");
-  int month = CallDateMethod(val, "getMonth") + 1;
-  int day = CallDateMethod(val, "getDate");
-  int hours = CallDateMethod(val, "getHours");
-  int minutes = CallDateMethod(val, "getMinutes");
-  int seconds = CallDateMethod(val, "getSeconds");
+  int year = CallDateMethod(val, "getUTCFullYear");
+  int month = CallDateMethod(val, "getUTCMonth") + 1;
+  int day = CallDateMethod(val, "getUTCDate");
+  int hours = CallDateMethod(val, "getUTCHours");
+  int minutes = CallDateMethod(val, "getUTCMinutes");
+  int seconds = CallDateMethod(val, "getUTCSeconds");
+  //TODO: int milliseconds = CallDateMethod(val, "getUTCMilliseconds");
   oracle::occi::Date* d = new oracle::occi::Date(env, year, month, day, hours, minutes, seconds);
   return d;
 }

test/integration.js

@@ -94,7 +94,7 @@ exports['IntegrationTest'] = nodeunit.testCase({
 
   "datatypes": function(test) {
     var self = this;
-    var date1 = new Date(2011, 10, 30, 1, 2, 3);
+	var date1 = new Date(2011, 10, 30, 1, 2, 3);
     var date2 = new Date(2011, 11, 1, 1, 2, 3);
     self.connection.execute(
       "INSERT INTO datatype_test "
@@ -126,8 +126,7 @@ exports['IntegrationTest'] = nodeunit.testCase({
           test.equal(results[0]['TNCHAR'], "tnchar value                                                                                                                                                                                                                                                   ");
           test.equal(results[0]['TNUMBER'], 42.5);
           test.equal(results[0]['TDATE'].getTime(), date1.getTime());
-          var date2Timestamp = new Date(2011, 11, 1, 0, 0, 0); // same as date2 but without time
-          test.equal(results[0]['TTIMESTAMP'].getTime(), date2Timestamp.getTime());
+          test.equal(results[0]['TTIMESTAMP'].getTime(), date2.getTime());
           test.equal(results[0]['TCLOB'], "tclob value");
           test.equal(results[0]['TNCLOB'], "tnclob value");
           // todo: test.equal(results[0]['TBLOB'], null);