Keys stick if held when input is unlocked

[cartertemm]

Steps to reproduce:

Lock input with your preferred keystroke, I'm using ctrl+shift+a. then keep a modifier held down, shift is probably the easiest in this example. Now unlock input, keeping said key held.

Actual behavior:

At first everything seems to work, but try arrowing around a document. You'll see text being selected unnecessarily. This is because shift is stuck e.g. still reporting as being held by windows. You can fix by locking and unlocking quickly, making sure that a modifier isn't held this time around.

Expected behavior:

The pressed modifier should be ignored.

[jmdaweb]

Hi Carter. The issue has been reproduced successfully here. I'll try to fix it in the next few days. Regards. El 22/04/2019 a las 18:40, Carter Temm escribió: Steps to reproduce: Lock input with your preferred keystroke, I'm using ctrl+shift+a. then keep a modifier held down, shift is probably the easiest in this example. Now unlock input, keeping said key held. Actual behavior: At first everything seems to work, but try arrowing around a document. You'll see text being selected unnecessarily. This is because shift is stuck e.g. still reporting as being held by windows. You can fix by locking and unlocking quickly, making sure that a modifier isn't held this time around. Expected behavior: The pressed modifier should be ignored. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#1>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACK5X3ECO52KZRKAGFG4UMTPRXS6TANCNFSM4HHQ44LQ>.

[jmdaweb]

Hi again.
I have experimented this problem with the add-on disabled, although I can't reproduce it. I think this problem is not related to the add-on. @ivnc what is your opinion about that?

[ivnc]

Hi.

I've also experienced certain problems with stuck keys, unrelated to InputLock. Anyway, I don't know if they are caused by NVDA or Windows itself, nor if this one in special should be andled by this addon to afix it.

Regards.

[cartertemm]

Hi,
I've also seen this issue elsewhere.
My testing seems to suggest the culprit as the low-level input hook itself. In a nutshell, keys that are currently held when the hook is disabled are left stuck down. My suggestion is to check for and release currently held modifiers when input is unlocked.