Skip to content

Rebase Development onto Main #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jldsilva merged 4 commits into from
May 19, 2025
Merged

Rebase Development onto Main #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3dd43d0
GlobalExceptionHandler middleware fix
jldsilva May 19, 2025
85ee813
Merge pull request #7 from jldsilva/GlobalExceptionHandler_fix
jldsilva May 19, 2025
ce783b8
Unit Tests fix
jldsilva May 19, 2025
f01e9aa
Merge pull request #9 from jldsilva/Unit_Tests_fix
jldsilva May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 52 additions & 2 deletions InvoiceReminder.API.UnitTests/Endpoints/InvoiceEndpointsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ public async Task GetInvoiceById_WhenUserIsNotAuthenticated_ShouldReturnUnauthor
}

[TestMethod]
public async Task GetInvoiceById_WhenUserIsAuthenticatedButServiceFails_ShouldReturnInternalServerError()
public async Task GetInvoiceById_WhenUserIsAuthenticatedButServiceFails_ShouldReturnBadRequest()
{
// Arrange
var id = Guid.NewGuid();
Expand All @@ -200,6 +200,31 @@ public async Task GetInvoiceById_WhenUserIsAuthenticatedButServiceFails_ShouldRe
var response = await _client.SendAsync(request);
var result = await response.Content.ReadFromJsonAsync<ProblemDetails>();

// Assert
_ = _invoiceAppService.Received(1).GetByIdAsync(Arg.Any<Guid>());
response.StatusCode.ShouldBe(HttpStatusCode.BadRequest);
_ = result.ShouldNotBeNull();
_ = result.ShouldBeOfType<ProblemDetails>();
}

[TestMethod]
public async Task GetInvoiceById_WhenUserIsAuthenticatedButServiceFails_ShouldReturnInternalServerError()
{
// Arrange
var id = Guid.NewGuid();
var request = new HttpRequestMessage(HttpMethod.Get, $"/api/invoice/{id}");
request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", "test_token");

_ = _invoiceAppService.GetByIdAsync(Arg.Any<Guid>()).ThrowsAsync<ApplicationException>();

_ = _authorizationService.AuthorizeAsync(Arg.Any<ClaimsPrincipal>(), Arg.Any<object>(),
Arg.Any<IEnumerable<IAuthorizationRequirement>>())
.Returns(Task.FromResult(AuthorizationResult.Success()));

// Act
var response = await _client.SendAsync(request);
var result = await response.Content.ReadFromJsonAsync<ProblemDetails>();

// Assert
_ = _invoiceAppService.Received(1).GetByIdAsync(Arg.Any<Guid>());
response.StatusCode.ShouldBe(HttpStatusCode.InternalServerError);
Expand Down Expand Up @@ -290,7 +315,7 @@ public async Task GetInvoiceByBarcode_WhenUserIsNotAuthenticated_ShouldReturnUna
}

[TestMethod]
public async Task GetInvoiceByBarcode_WhenUserIsAuthenticatedButServiceFails_ShouldReturnInternalServerError()
public async Task GetInvoiceByBarcode_WhenUserIsAuthenticatedButServiceFails_ShouldReturnBadRequest()
{
// Arrange
var value = "12345678901234567890123456789012345678901234";
Expand All @@ -307,6 +332,31 @@ public async Task GetInvoiceByBarcode_WhenUserIsAuthenticatedButServiceFails_Sho
var response = await _client.SendAsync(request);
var result = await response.Content.ReadFromJsonAsync<ProblemDetails>();

// Assert
_ = _invoiceAppService.Received(1).GetByBarcodeAsync(Arg.Any<string>());
response.StatusCode.ShouldBe(HttpStatusCode.BadRequest);
_ = result.ShouldNotBeNull();
_ = result.ShouldBeOfType<ProblemDetails>();
}

[TestMethod]
public async Task GetInvoiceByBarcode_WhenUserIsAuthenticatedButServiceFails_ShouldReturnInternalServerError()
{
// Arrange
var value = "12345678901234567890123456789012345678901234";
var request = new HttpRequestMessage(HttpMethod.Get, $"/api/invoice/get_by_barcode/{value}");
request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", "test_token");

_ = _invoiceAppService.GetByBarcodeAsync(Arg.Any<string>()).ThrowsAsync<ApplicationException>();

_ = _authorizationService.AuthorizeAsync(Arg.Any<ClaimsPrincipal>(), Arg.Any<object>(),
Arg.Any<IEnumerable<IAuthorizationRequirement>>())
.Returns(Task.FromResult(AuthorizationResult.Success()));

// Act
var response = await _client.SendAsync(request);
var result = await response.Content.ReadFromJsonAsync<ProblemDetails>();

// Assert
_ = _invoiceAppService.Received(1).GetByBarcodeAsync(Arg.Any<string>());
response.StatusCode.ShouldBe(HttpStatusCode.InternalServerError);
Expand Down
54 changes: 52 additions & 2 deletions InvoiceReminder.API.UnitTests/Endpoints/JobScheduleEndPointsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ public async Task GetJobScheduleById_WhenUserIsNotAuthenticated_ShouldReturnUnau
}

[TestMethod]
public async Task GetJobScheduleById_WhenUserIsAuthenticatedButServiceFails_ShouldReturnInternalServerError()
public async Task GetJobScheduleById_WhenUserIsAuthenticatedButServiceFails_ShouldReturnBadRequest()
{
// Arrange
var id = Guid.NewGuid();
Expand All @@ -191,6 +191,31 @@ public async Task GetJobScheduleById_WhenUserIsAuthenticatedButServiceFails_Shou
var response = await _client.SendAsync(request);
var result = await response.Content.ReadFromJsonAsync<ProblemDetails>();

// Assert
_ = _jobScheduleAppService.Received(1).GetByIdAsync(Arg.Any<Guid>());
response.StatusCode.ShouldBe(HttpStatusCode.BadRequest);
_ = result.ShouldNotBeNull();
_ = result.ShouldBeOfType<ProblemDetails>();
}

[TestMethod]
public async Task GetJobScheduleById_WhenUserIsAuthenticatedButServiceFails_ShouldReturnInternalServerError()
{
// Arrange
var id = Guid.NewGuid();
var request = new HttpRequestMessage(HttpMethod.Get, $"/api/job_schedule/{id}");
request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", "test_token");

_ = _jobScheduleAppService.GetByIdAsync(Arg.Any<Guid>()).ThrowsAsync(new ApplicationException("Service error"));

_ = _authorizationService.AuthorizeAsync(Arg.Any<ClaimsPrincipal>(), Arg.Any<object>(),
Arg.Any<IEnumerable<IAuthorizationRequirement>>())
.Returns(Task.FromResult(AuthorizationResult.Success()));

// Act
var response = await _client.SendAsync(request);
var result = await response.Content.ReadFromJsonAsync<ProblemDetails>();

// Assert
_ = _jobScheduleAppService.Received(1).GetByIdAsync(Arg.Any<Guid>());
response.StatusCode.ShouldBe(HttpStatusCode.InternalServerError);
Expand Down Expand Up @@ -285,6 +310,31 @@ public async Task GetJobScheduleByUserId_WhenUserIsNotAuthenticated_ShouldReturn
response.StatusCode.ShouldBe(HttpStatusCode.Unauthorized);
}

[TestMethod]
public async Task GetJobScheduleByUserId_WhenUserIsAuthenticatedButServiceFails_ShouldReturnBadRequest()
{
// Arrange
var id = Guid.NewGuid();
var request = new HttpRequestMessage(HttpMethod.Get, $"/api/job_schedule/get_by_user_id/{id}");
request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", "test_token");

_ = _jobScheduleAppService.GetByUserIdAsync(Arg.Any<Guid>()).ThrowsAsync<ArgumentException>();

_ = _authorizationService.AuthorizeAsync(Arg.Any<ClaimsPrincipal>(), Arg.Any<object>(),
Arg.Any<IEnumerable<IAuthorizationRequirement>>())
.Returns(Task.FromResult(AuthorizationResult.Success()));

// Act
var response = await _client.SendAsync(request);
var result = await response.Content.ReadFromJsonAsync<ProblemDetails>();

// Assert
_ = _jobScheduleAppService.Received(1).GetByUserIdAsync(Arg.Any<Guid>());
response.StatusCode.ShouldBe(HttpStatusCode.BadRequest);
_ = result.ShouldNotBeNull();
_ = result.ShouldBeOfType<ProblemDetails>();
}

[TestMethod]
public async Task GetJobScheduleByUserId_WhenUserIsAuthenticatedButServiceFails_ShouldReturnInternalServerError()
{
Expand All @@ -293,7 +343,7 @@ public async Task GetJobScheduleByUserId_WhenUserIsAuthenticatedButServiceFails_
var request = new HttpRequestMessage(HttpMethod.Get, $"/api/job_schedule/get_by_user_id/{id}");
request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", "test_token");

_ = _jobScheduleAppService.GetByUserIdAsync(Arg.Any<Guid>()).ThrowsAsync(new ArgumentException("Service error"));
_ = _jobScheduleAppService.GetByUserIdAsync(Arg.Any<Guid>()).ThrowsAsync<ApplicationException>();

_ = _authorizationService.AuthorizeAsync(Arg.Any<ClaimsPrincipal>(), Arg.Any<object>(),
Arg.Any<IEnumerable<IAuthorizationRequirement>>())
Expand Down
56 changes: 52 additions & 4 deletions InvoiceReminder.API.UnitTests/Endpoints/ScanEmailDefinitionEndpointsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,31 @@ public async Task GetScanEmailDefinitionById_WhenUserIsNotAuthenticated_ShouldRe
response.StatusCode.ShouldBe(HttpStatusCode.Unauthorized);
}

[TestMethod]
public async Task GetScanEmailDefinitionById_WhenUserIsAuthenticatedButServiceFails_ShouldReturnBadRequest()
{
// Arrange
var id = Guid.NewGuid();
var request = new HttpRequestMessage(HttpMethod.Get, $"/api/scan_email/{id}");
request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", "test_token");

_ = _scanEmailDefinitionAppService.GetByIdAsync(Arg.Any<Guid>()).ThrowsAsync<ArgumentException>();

_ = _authorizationService.AuthorizeAsync(Arg.Any<ClaimsPrincipal>(), Arg.Any<object>(),
Arg.Any<IEnumerable<IAuthorizationRequirement>>())
.Returns(Task.FromResult(AuthorizationResult.Success()));

// Act
var response = await _client.SendAsync(request);
var result = await response.Content.ReadFromJsonAsync<ProblemDetails>();

// Assert
_ = _scanEmailDefinitionAppService.Received(1).GetByIdAsync(Arg.Any<Guid>());
response.StatusCode.ShouldBe(HttpStatusCode.BadRequest);
_ = result.ShouldNotBeNull();
_ = result.ShouldBeOfType<ProblemDetails>();
}

[TestMethod]
public async Task GetScanEmailDefinitionById_WhenUserIsAuthenticatedButServiceFails_ShouldReturnInternalServerError()
{
Expand All @@ -190,8 +215,7 @@ public async Task GetScanEmailDefinitionById_WhenUserIsAuthenticatedButServiceFa
var request = new HttpRequestMessage(HttpMethod.Get, $"/api/scan_email/{id}");
request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", "test_token");

_ = _scanEmailDefinitionAppService.GetByIdAsync(Arg.Any<Guid>())
.ThrowsAsync(new ArgumentException("Service error"));
_ = _scanEmailDefinitionAppService.GetByIdAsync(Arg.Any<Guid>()).ThrowsAsync<ApplicationException>();

_ = _authorizationService.AuthorizeAsync(Arg.Any<ClaimsPrincipal>(), Arg.Any<object>(),
Arg.Any<IEnumerable<IAuthorizationRequirement>>())
Expand Down Expand Up @@ -297,6 +321,31 @@ public async Task GetScanEmailDefinitionByUserId_WhenUserIsNotAuthenticated_Shou
response.StatusCode.ShouldBe(HttpStatusCode.Unauthorized);
}

[TestMethod]
public async Task GetScanEmailDefinitionByUserId_WhenUserIsAuthenticatedButServiceFails_ShouldReturnBadRequest()
{
// Arrange
var id = Guid.NewGuid();
var request = new HttpRequestMessage(HttpMethod.Get, $"/api/scan_email/get_by_user_id/{id}");
request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", "test_token");

_ = _scanEmailDefinitionAppService.GetByUserIdAsync(Arg.Any<Guid>()).ThrowsAsync<ArgumentException>();

_ = _authorizationService.AuthorizeAsync(Arg.Any<ClaimsPrincipal>(), Arg.Any<object>(),
Arg.Any<IEnumerable<IAuthorizationRequirement>>())
.Returns(Task.FromResult(AuthorizationResult.Success()));

// Act
var response = await _client.SendAsync(request);
var result = await response.Content.ReadFromJsonAsync<ProblemDetails>();

// Assert
_ = _scanEmailDefinitionAppService.Received(1).GetByUserIdAsync(Arg.Any<Guid>());
response.StatusCode.ShouldBe(HttpStatusCode.BadRequest);
_ = result.ShouldNotBeNull();
_ = result.ShouldBeOfType<ProblemDetails>();
}

[TestMethod]
public async Task GetScanEmailDefinitionByUserId_WhenUserIsAuthenticatedButServiceFails_ShouldReturnInternalServerError()
{
Expand All @@ -305,8 +354,7 @@ public async Task GetScanEmailDefinitionByUserId_WhenUserIsAuthenticatedButServi
var request = new HttpRequestMessage(HttpMethod.Get, $"/api/scan_email/get_by_user_id/{id}");
request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", "test_token");

_ = _scanEmailDefinitionAppService.GetByUserIdAsync(Arg.Any<Guid>())
.ThrowsAsync(new ArgumentException("Service error"));
_ = _scanEmailDefinitionAppService.GetByUserIdAsync(Arg.Any<Guid>()).ThrowsAsync<ApplicationException>();

_ = _authorizationService.AuthorizeAsync(Arg.Any<ClaimsPrincipal>(), Arg.Any<object>(),
Arg.Any<IEnumerable<IAuthorizationRequirement>>())
Expand Down
54 changes: 52 additions & 2 deletions InvoiceReminder.API.UnitTests/Endpoints/UserEndpointsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,31 @@ public async Task GetUserById_WhenUserIsNotAuthenticated_ShouldReturnUnauthorize
response.StatusCode.ShouldBe(HttpStatusCode.Unauthorized);
}

[TestMethod]
public async Task GetUserById_WhenUserIsAuthenticatedButServiceFails_ShouldReturnBadRequest()
{
// Arrange
var id = Guid.NewGuid();
var request = new HttpRequestMessage(HttpMethod.Get, $"/api/user/{id}");
request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", "test_token");

_ = _userAppService.GetByIdAsync(Arg.Any<Guid>()).ThrowsAsync<ArgumentException>();

_ = _authorizationService.AuthorizeAsync(Arg.Any<ClaimsPrincipal>(), Arg.Any<object>(),
Arg.Any<IEnumerable<IAuthorizationRequirement>>())
.Returns(Task.FromResult(AuthorizationResult.Success()));

// Act
var response = await _client.SendAsync(request);
var result = await response.Content.ReadFromJsonAsync<ProblemDetails>();

// Assert
_ = _userAppService.Received(1).GetByIdAsync(Arg.Any<Guid>());
response.StatusCode.ShouldBe(HttpStatusCode.BadRequest);
_ = result.ShouldNotBeNull();
_ = result.ShouldBeOfType<ProblemDetails>();
}

[TestMethod]
public async Task GetUserById_WhenUserIsAuthenticatedButServiceFails_ShouldReturnInternalServerError()
{
Expand All @@ -187,7 +212,7 @@ public async Task GetUserById_WhenUserIsAuthenticatedButServiceFails_ShouldRetur
var request = new HttpRequestMessage(HttpMethod.Get, $"/api/user/{id}");
request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", "test_token");

_ = _userAppService.GetByIdAsync(Arg.Any<Guid>()).ThrowsAsync(new ArgumentException("Service error"));
_ = _userAppService.GetByIdAsync(Arg.Any<Guid>()).ThrowsAsync<ApplicationException>();

_ = _authorizationService.AuthorizeAsync(Arg.Any<ClaimsPrincipal>(), Arg.Any<object>(),
Arg.Any<IEnumerable<IAuthorizationRequirement>>())
Expand Down Expand Up @@ -287,6 +312,31 @@ public async Task GetUserByEmail_WhenUserIsNotAuthenticated_ShouldReturnUnauthor
response.StatusCode.ShouldBe(HttpStatusCode.Unauthorized);
}

[TestMethod]
public async Task GetUserByEmail_WhenUserIsAuthenticatedButServiceFails_ShouldReturnBadRequest()
{
// Arrange
var value = "test_user@mail_com";
var request = new HttpRequestMessage(HttpMethod.Get, $"/api/user/get_by_email/{value}");
request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", "test_token");

_ = _userAppService.GetByEmailAsync(Arg.Any<string>()).ThrowsAsync<ArgumentException>();

_ = _authorizationService.AuthorizeAsync(Arg.Any<ClaimsPrincipal>(), Arg.Any<object>(),
Arg.Any<IEnumerable<IAuthorizationRequirement>>())
.Returns(Task.FromResult(AuthorizationResult.Success()));

// Act
var response = await _client.SendAsync(request);
var result = await response.Content.ReadFromJsonAsync<ProblemDetails>();

// Assert
_ = _userAppService.Received(1).GetByEmailAsync(Arg.Any<string>());
response.StatusCode.ShouldBe(HttpStatusCode.BadRequest);
_ = result.ShouldNotBeNull();
_ = result.ShouldBeOfType<ProblemDetails>();
}

[TestMethod]
public async Task GetUserByEmail_WhenUserIsAuthenticatedButServiceFails_ShouldReturnInternalServerError()
{
Expand All @@ -295,7 +345,7 @@ public async Task GetUserByEmail_WhenUserIsAuthenticatedButServiceFails_ShouldRe
var request = new HttpRequestMessage(HttpMethod.Get, $"/api/user/get_by_email/{value}");
request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", "test_token");

_ = _userAppService.GetByEmailAsync(Arg.Any<string>()).ThrowsAsync(new ArgumentException("Service error"));
_ = _userAppService.GetByEmailAsync(Arg.Any<string>()).ThrowsAsync<ApplicationException>();

_ = _authorizationService.AuthorizeAsync(Arg.Any<ClaimsPrincipal>(), Arg.Any<object>(),
Arg.Any<IEnumerable<IAuthorizationRequirement>>())
Expand Down
4 changes: 3 additions & 1 deletion InvoiceReminder.API/Exceptions/GlobalExceptionHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ public async ValueTask<bool> TryHandleAsync(HttpContext httpContext, Exception e

httpContext.Response.StatusCode = exception switch
{
ApplicationException => StatusCodes.Status400BadRequest,
ArgumentException or
ArgumentNullException or
BadHttpRequestException => StatusCodes.Status400BadRequest,
_ => StatusCodes.Status500InternalServerError
};

Expand Down