Manchester school capacity vs occupancy (possible mixup?)

[carlhiggs]

Reviewing the Manchester school data, I noticed a possible ambiguity with capacity and occupancy --- on a particular couple of lines these are switched. I'm not sure about the distinction between these two fields (we allocated schools based on enrolment statistics by gender, extending the Melbourne R-based workflow), but thought worth checking with you @CorinStaves / @Qinnnnn (hope things are all well with you, btw!) in case this could be an oversight:

silo/useCases/manchester/src/main/java/de/tum/bgu/msm/io/SchoolReaderMCR.java

Lines 59 to 60 in ce00db2

	int capacity = Integer.parseInt(lineElements[posOccupancy]);
	int occupancy = Integer.parseInt(lineElements[posCapacity]);

[carlhiggs]

This pattern is also in the upstream school extension code:

silo/extensions/schools/src/main/java/de/tum/bgu/msm/schools/SchoolReaderImpl.java

Lines 53 to 54 in 4addce0

	int capacity = Integer.parseInt(lineElements[posOccupancy]);
	int occupancy = Integer.parseInt(lineElements[posCapacity]);

[carlhiggs]

The apparent mix up in reading occupancy and capacity for the schools extension is in the MSM Silo master branch, so I will raise the issue there:
https://github.com/msmobility/silo/blob/e797ae8d951993522afd471482985efb2e772149/extensions/schools/src/main/java/de/tum/bgu/msm/schools/SchoolReaderImpl.java#L52-L53

[carlhiggs]

@usr110, @ismailsaadi and @CorinStaves --- fyi Nico confirmed this is a bug in the Master SILO that has been copied over for Manchester's use case (see thread above; there's a pull request to fix it); you might want to update the Manchester use case at some point on the PHM side; I'll make the update here. I don't expect it will cause any meaningful changes as capacity and occupancy would be highly correlated I expect, but its possible things may slightly shift. The MCR team may want to confirm.