Commit 8bec6ba
authored
Job scheduler fix related to status check (linkedin#332)
## Summary
<!--- HINT: Replace #nnn with corresponding Issue number, if you are
fixing an existing issue -->
[Issue](https://github.com/linkedin/openhouse/issues/#nnn)] Briefly
discuss the summary of the changes made in this
pull request in 2-3 lines.
There is a slight delay in getting the submitted job id and hence last
few submitted jobs might not available in the submitted queue if the
completed flag is marked before submission completion (until all future
get completed). Moved job submission completion flag (after future get
is done for all the submitted jobs) so that all the jobs are added in
the queue for job status check.
## Changes
- [ ] Client-facing API Changes
- [ ] Internal API Changes
- [x] Bug Fixes
- [ ] New Features
- [ ] Performance Improvements
- [ ] Code Style
- [ ] Refactoring
- [ ] Documentation
- [ ] Tests
For all the boxes checked, please include additional details of the
changes made in this pull request.
## Testing Done
Local builds passed and verified exiting tests.
<!--- Check any relevant boxes with "x" -->
- [ ] Manually Tested on local docker setup. Please include commands
ran, and their output.
- [ ] Added new tests for the changes made.
- [ ] Updated existing tests to reflect the changes made.
- [ ] No tests added or updated. Please explain why. If unsure, please
feel free to ask for help.
- [x] Some other form of testing like staging or soak time in
production. Please explain.
For all the boxes checked, include a detailed description of the testing
done for the changes made in this pull request.
# Additional Information
- [ ] Breaking Changes
- [ ] Deprecations
- [ ] Large PR broken into smaller PRs, and PR plan linked in the
description.
For all the boxes checked, include additional details of the changes
made in this pull request.1 parent 97feb7c commit 8bec6ba
1 file changed
Lines changed: 4 additions & 1 deletion
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
762 | 762 | | |
763 | 763 | | |
764 | 764 | | |
765 | | - | |
766 | 765 | | |
767 | 766 | | |
768 | 767 | | |
| |||
774 | 773 | | |
775 | 774 | | |
776 | 775 | | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
| 779 | + | |
777 | 780 | | |
778 | 781 | | |
779 | 782 | | |
| |||
0 commit comments