Fix otel config bug (linkedin#383)

Author: jiang95-dev

services/common/src/main/java/com/linkedin/openhouse/common/metrics/DefaultOtelConfig.java

@@ -1,5 +1,7 @@
 package com.linkedin.openhouse.common.metrics;
 
+import static io.opentelemetry.semconv.resource.attributes.ResourceAttributes.SERVICE_NAME;
+
 import io.opentelemetry.api.OpenTelemetry;
 import io.opentelemetry.api.common.Attributes;
 import io.opentelemetry.api.common.AttributesBuilder;
@@ -34,7 +36,7 @@ private static Attributes getCommonAttributes() {
     String appName = System.getenv("APP_NAME");
     String clusterName = System.getenv("CLUSTER_NAME");
     if (StringUtils.isNotEmpty(appName)) {
-      attributesBuilder.put("service_name", appName);
+      attributesBuilder.put(SERVICE_NAME, appName);
     }
     if (StringUtils.isNotEmpty(clusterName)) {
       attributesBuilder.put("cluster_name", clusterName);

services/common/src/main/java/com/linkedin/openhouse/common/metrics/OpenHouseOtelEmitter.java

@@ -65,7 +65,6 @@ public synchronized void gauge(String scope, String metric, long value, Attribut
           meter.gaugeBuilder(metric).ofLongs().setUnit(TimeUnit.MILLISECONDS.toString());
       if (attributes == null) {
         gaugeBuilder.buildWithCallback(measurement -> measurement.record(value));
-        return;
       } else {
         gaugeBuilder.buildWithCallback(measurement -> measurement.record(value, attributes));
       }