Skip to content

Commit afe89cd

Browse files
committed
Updated libraries to remove security vulnerability
Fixed tests Update ReadingBusesTestsDummy.cs Update ReadingBusesAPI.csproj
1 parent c338a7b commit afe89cd

4 files changed

Lines changed: 18 additions & 11 deletions

File tree

.editorconfig

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ dotnet_style_prefer_simplified_boolean_expressions = true:suggestion
6767
dotnet_style_prefer_compound_assignment = true:suggestion
6868
dotnet_style_prefer_simplified_interpolation = true:suggestion
6969
dotnet_style_namespace_match_folder = true:suggestion
70+
dotnet_style_prefer_collection_expression = when_types_loosely_match:suggestion
7071
###############################
7172
# C# Coding Conventions #
7273
###############################
@@ -137,6 +138,8 @@ csharp_style_expression_bodied_local_functions = false:silent
137138
csharp_style_prefer_null_check_over_type_check = true:suggestion
138139
csharp_style_prefer_local_over_anonymous_function = true:suggestion
139140
csharp_style_prefer_index_operator = true:suggestion
141+
csharp_style_prefer_top_level_statements = true:silent
142+
csharp_style_prefer_primary_constructors = true:suggestion
140143
###############################
141144
# VB Coding Conventions #
142145
###############################

ReadingBuses API Tests/Live Server Tests/ReadingBusesTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ public void GetLocations()
138138
[Test]
139139
[TestCase("17")]
140140
[TestCase("1")]
141-
[TestCase("X4")]
141+
[TestCase("4a")]
142142
public void GetService(string serviceNumber)
143143
{
144144
BusService service = ReadingBuses.GetInstance().GetService(serviceNumber, Company.ReadingBuses);

ReadingBuses API Tests/ReadingBuses API Tests.csproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<Project Sdk="Microsoft.NET.Sdk">
1+
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
44
<TargetFramework>net8.0</TargetFramework>
@@ -10,12 +10,12 @@
1010
</PropertyGroup>
1111

1212
<ItemGroup>
13-
<PackageReference Include="nunit" Version="4.1.0" />
14-
<PackageReference Include="NUnit3TestAdapter" Version="4.5.0">
13+
<PackageReference Include="nunit" Version="4.3.2" />
14+
<PackageReference Include="NUnit3TestAdapter" Version="5.0.0">
1515
<PrivateAssets>all</PrivateAssets>
1616
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
1717
</PackageReference>
18-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.10.0" />
18+
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0" />
1919
</ItemGroup>
2020

2121
<ItemGroup>

ReadingBusesAPI/ReadingBusesAPI.csproj

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,10 @@
77
<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
88
<PackageId>ReadingBusesAPI</PackageId>
99
<Version>3.1.0</Version>
10-
<AssemblyVersion>3.0.0.0</AssemblyVersion>
11-
<FileVersion>3.0.0.0</FileVersion>
10+
<AssemblyVersion>3.1.5.0</AssemblyVersion>
11+
<FileVersion>3.1.5.0</FileVersion>
1212
<NeutralLanguage>en-GB</NeutralLanguage>
13-
<PackageReleaseNotes>* Updated system.text.json to v8.0.4
14-
* Add support for Oxford Bus Company and Carousel Buses</PackageReleaseNotes>
13+
<PackageReleaseNotes>* Updated libraries to remove security vulnerability</PackageReleaseNotes>
1514
<RepositoryUrl>https://github.com/jfoot/Reading-Buses-API</RepositoryUrl>
1615
<PackageIcon>LogoHighRes.jpg</PackageIcon>
1716
<RepositoryType>GitHub</RepositoryType>
@@ -25,13 +24,14 @@ This includes bus services operated by Reading Buses and subsidiaries such as, T
2524
The library supports the List of Bus Stops, Live Vehicle Positions, Live Journey Details, Stop Predictions, List of Lines, Line Patterns, Timetabled Journeys, Tracking History and the Vehicle Position History API.
2625

2726
Get your own API Keys from: https://reading-opendata.r2p.com/api-service</Description>
28-
<Copyright>Jonathan Foot © 2024</Copyright>
27+
<Copyright>Jonathan Foot © 2025</Copyright>
2928
<Authors>Jonathan Foot</Authors>
3029
<Company>Jonathan Foot</Company>
3130
<Product>Reading Buses API</Product>
3231
<ApplicationIcon>LogoHighRes.ico</ApplicationIcon>
3332
<GenerateDocumentationFile>True</GenerateDocumentationFile>
3433
<Title>ReadingBusesAPI</Title>
34+
<PackageReadmeFile>README.md</PackageReadmeFile>
3535
</PropertyGroup>
3636

3737
<ItemGroup>
@@ -40,6 +40,10 @@ Get your own API Keys from: https://reading-opendata.r2p.com/api-service</Descri
4040
<Pack>True</Pack>
4141
<PackagePath></PackagePath>
4242
</None>
43+
<None Include="..\README.md">
44+
<Pack>True</Pack>
45+
<PackagePath>\</PackagePath>
46+
</None>
4347
<None Include="LogoHighRes.jpg">
4448
<Pack>True</Pack>
4549
<PackagePath></PackagePath>
@@ -54,7 +58,7 @@ Get your own API Keys from: https://reading-opendata.r2p.com/api-service</Descri
5458
</ItemGroup>
5559

5660
<ItemGroup>
57-
<PackageReference Include="System.Text.Json" Version="8.0.4" />
61+
<PackageReference Include="System.Text.Json" Version="9.0.4" />
5862
</ItemGroup>
5963

6064
</Project>

0 commit comments

Comments
 (0)