Readability gh branch integration

[tim-hilde]

Describe the bug

The new gh branch integration is not easy to read:

Version info:

commit=, build date=, build source=Homebrew, version=0.61.0, os=darwin, arch=arm64, git version=2.53.0

Terminal info:

tmux within ghostty

[stefanhaller]

The readability of this is determined by your terminal's color palette configuration. Try a different theme (ghostty +list-themes).

[tim-hilde]

Shouldn't it first use the colors defined by lazygit themes?

[stefanhaller]

Lazygit doesn't have themes in that sense. It has config options for overriding some of the colors for specific things, but for the most part it simply uses the standard palette colors. And here, too: the color for an open PR is just "green", and the text color is the default text color. We'd have to add config options if you wanted to tweak these, but honestly I think it's easier to tweak your terminal's color palette instead.

[tim-hilde]

Well then I feel lazygit is not using the correct colors from the terminals palette. I am not having issues with the color of the pill (green, red, purple) but with the text inside it. The contrast is way off compared to other colors

[stefanhaller]

I was actually wrong, we use white on green and not default text color on green.

I remember experimenting with this when I implemented it; I also tried black-on-green, which is actually more readable on my particular terminal's palette, but might not be on others. Also, I wanted it to look more similar to GitHub's design, that's why I preferred the white text.

I don't remember why I didn't try using hex colors for the PR pills to make them look exactly like GitHub's. I opened #5480 to try this, please give this a try and report if this works better for you. It does have problems though, see the PR description for details.