Plugin directories are inconsistent

[chrislovecnm]

We are using ~/.jx and ~/.jx-gitops for plugins, while jx3 is using ~/.jx3 now. See:

jx-gitops/pkg/plugins/helpers.go

Lines 34 to 42 in fac11d0

	func PluginBinDirFunc(fn func(string) string) (string, error) {
	for _, e := range []string{"JX_GITOPS_HOME", "JX3_HOME", "JX_HOME"} {
	v := fn(e)
	if v != "" {
	return homedir.PluginBinDir(v, ".jx")
	}
	}
	return homedir.PluginBinDir("", ".jx")
	}

jx-gitops/pkg/plugins/helpers.go

Line 129 in fac11d0

pluginBinDir, err := homedir.PluginBinDir(os.Getenv("JX_GITOPS_HOME"), ".jx-gitops")

Which directory should it use?