Hi!
In your readme, you write "The script by default assumes you are going to run this as a rootless user", but SAMBA_SERVER_PORT is 445 which is within the privileged ports by default. In start.sh:45 this variable is not only used on the container side but also on the host side.
For now, i changed the line from
-p ${SAMBA_SERVER_PORT}:${SAMBA_SERVER_PORT}
to
-p ${SAMBA_SERVER_PORT}:445
and SAMBA_SERVER_PORT to 1445
Should a change like this be applied or am I missing something?
Hi!
In your readme, you write "The script by default assumes you are going to run this as a rootless user", but SAMBA_SERVER_PORT is 445 which is within the privileged ports by default. In start.sh:45 this variable is not only used on the container side but also on the host side.
For now, i changed the line from
-p ${SAMBA_SERVER_PORT}:${SAMBA_SERVER_PORT}
to
-p ${SAMBA_SERVER_PORT}:445
and SAMBA_SERVER_PORT to 1445
Should a change like this be applied or am I missing something?