From 3b2f43bac09a9829be77c7b49e228653c175b5d3 Mon Sep 17 00:00:00 2001 From: imamsutono Date: Tue, 23 Jan 2018 10:13:52 +0700 Subject: [PATCH 1/3] Change import PropTypes from react to import from prop-types --- src/Prompt.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Prompt.js b/src/Prompt.js index d778d0a..180a59b 100644 --- a/src/Prompt.js +++ b/src/Prompt.js @@ -1,4 +1,4 @@ -import React, { Component, PropTypes } from 'react'; +import React, { Component } from 'react'; import { Modal, Platform, @@ -7,6 +7,7 @@ import { TouchableWithoutFeedback, View } from 'react-native'; +import PropTypes from 'prop-types'; import styles from './styles'; export default class Prompt extends Component { From f192d242a873c097ff7324191f7114d81d08406a Mon Sep 17 00:00:00 2001 From: imamsutono Date: Tue, 23 Jan 2018 10:21:02 +0700 Subject: [PATCH 2/3] add prop-types dependencies --- package.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/package.json b/package.json index 8a55947..eafb5cf 100644 --- a/package.json +++ b/package.json @@ -34,6 +34,9 @@ ], "author": "Jack Hsu (http://jaysoo.ca/)", "license": "ISC", + "dependencies": { + "prop-types": "^15.6.0" + }, "devDependencies": { "appium": "^1.4.16", "babel-core": "^6.4.0", From 936d4732183a7e8bcd7fa50565058ae5c4153c51 Mon Sep 17 00:00:00 2001 From: imamsutono Date: Tue, 23 Jan 2018 10:29:49 +0700 Subject: [PATCH 3/3] Optional onCancel and onChangeText, can without cancel button --- src/Prompt.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Prompt.js b/src/Prompt.js index 180a59b..cb45cdc 100644 --- a/src/Prompt.js +++ b/src/Prompt.js @@ -16,11 +16,12 @@ export default class Prompt extends Component { visible: PropTypes.bool, defaultValue: PropTypes.string, placeholder: PropTypes.string, - onCancel: PropTypes.func.isRequired, + onCancel: PropTypes.func, cancelText: PropTypes.string, + cancelable: PropTypes.bool, onSubmit: PropTypes.func.isRequired, submitText: PropTypes.string, - onChangeText: PropTypes.func.isRequired, + onChangeText: PropTypes.func, borderColor: PropTypes.string, promptStyle: PropTypes.object, titleStyle: PropTypes.object, @@ -46,6 +47,7 @@ export default class Prompt extends Component { buttonTextStyle: {}, submitButtonStyle: {}, submitButtonTextStyle: {}, + cancelable: true, cancelButtonStyle: {}, cancelButtonTextStyle: {}, inputStyle: {},