fix: fix db refresh not running in transaction

Author: ShGKme

data/drop-schema.sql

@@ -1,9 +1,9 @@
 pragma foreign_keys = off;
 
-drop table if exists `users`;
-drop table if exists `meetups`;
 drop table if exists `agenda_items`;
-drop table if exists `images`;
 drop table if exists `participation`;
+drop table if exists `meetups`;
+drop table if exists `images`;
+drop table if exists `users`;
 
 pragma foreign_keys = on;

src/maintenance/database-manager.ts

@@ -1,7 +1,8 @@
 import * as fs from 'fs';
 import path from 'path';
-import { EntityManager } from 'mikro-orm';
+import { EntityManager, Transaction } from 'mikro-orm';
 import { getDataToSeed } from './seed-data';
+import { InternalServerErrorException } from '@nestjs/common';
 
 export class DatabaseManager {
   private dropSchemaPath = path.join(__dirname, '../../data/drop-schema.sql');
@@ -18,47 +19,34 @@ export class DatabaseManager {
     this.createSchemaQuery = fs.readFileSync(this.createSchemaPath, 'utf-8');
   }
 
-  private async execute(em: EntityManager, sql: string) {
+  private async execute(em: EntityManager, sql: string, ctx?: Transaction) {
     const lines = sql.split('\n').filter((i) => i.trim());
 
     for (const line of lines) {
-      await em.getConnection().execute(line);
+      await em.getConnection().execute(line, [], 'run', ctx);
     }
   }
 
-  dropSchema(em: EntityManager): Promise<void> {
-    return this.execute(em, this.dropSchemaQuery);
+  dropSchema(em: EntityManager, ctx?: Transaction): Promise<void> {
+    return this.execute(em, this.dropSchemaQuery, ctx);
   }
 
   seed(em: EntityManager): Promise<void> {
     const meetups = getDataToSeed();
     return em.persistAndFlush(meetups);
   }
 
-  createSchema(em: EntityManager): Promise<void> {
-    return this.execute(em, this.createSchemaQuery);
+  createSchema(em: EntityManager, ctx?: Transaction): Promise<void> {
+    return this.execute(em, this.createSchemaQuery, ctx);
   }
 
-  async refresh(em: EntityManager, attempt?: number): Promise<void> {
-    // TODO: add transaction here
-    // for some reason, thi.em.transactional fails with sqlite
-    // Not the best solution, but it seems to work
-    try {
-      await this.dropSchema(em);
-      await this.createSchema(em);
-      await this.seed(em);
-    } catch {
-      if (attempt < 10) {
-        return new Promise((resolve, reject) => {
-          setTimeout(() => {
-            this.refresh(em, attempt + 1)
-              .then(resolve)
-              .catch(reject);
-          }, 100);
-        });
-      } else {
-        throw new Error('Error on database refresh');
-      }
-    }
+  async refresh(em: EntityManager) {
+    return em.transactional(async (_em) => {
+      const ctx: Transaction = _em.getTransactionContext();
+      await this.dropSchema(_em, ctx);
+      await this.createSchema(_em, ctx);
+      await this.seed(_em);
+      return true;
+    });
   }
 }

src/maintenance/maintenance.service.ts

@@ -1,12 +1,19 @@
 import { EntityManager } from 'mikro-orm';
-import { Inject, Injectable } from '@nestjs/common';
+import {
+  Inject,
+  Injectable,
+  InternalServerErrorException,
+  Logger,
+} from '@nestjs/common';
 import { ConfigService } from '@nestjs/config';
 import { SchedulerRegistry } from '@nestjs/schedule';
 import { CronJob } from 'cron';
 import { DatabaseManager } from './database-manager';
 
 @Injectable()
 export class MaintenanceService {
+  private readonly logger = new Logger('Maintenance');
+
   constructor(
     private readonly em: EntityManager,
     private readonly schedulerRegistry: SchedulerRegistry,
@@ -29,7 +36,12 @@ export class MaintenanceService {
     return 'pong';
   }
 
-  dbRefresh() {
-    return this.databaseManager.refresh(this.em);
+  async dbRefresh() {
+    try {
+      await this.databaseManager.refresh(this.em);
+    } catch (e) {
+      this.logger.error(e.message);
+      throw new InternalServerErrorException('Error on DB refresh');
+    }
   }
 }