fix: handle macos 12 variants

Author: sangjanai

engine/cli/main.cc

@@ -148,7 +148,7 @@ int main(int argc, char* argv[]) {
         std::chrono::hours(24);
     should_check_for_latest_llamacpp_version = now > last_check;
   }
-  
+
   if (should_check_for_latest_llamacpp_version) {
     std::thread t1([]() {
       // TODO: namh current we only check for llamacpp. Need to add support for other engine
@@ -171,7 +171,7 @@ int main(int argc, char* argv[]) {
       };
 
       auto res = get_latest_version();
-      
+
       if (res.has_error()) {
         CTL_ERR("Failed to get latest llama.cpp version: " << res.error());
         return;

engine/extensions/local-engine/local_engine.cc

@@ -1001,4 +1001,4 @@ void LocalEngine::HandleNonOpenAiChatCompletion(
   }
 }
 
-}  // namespace cortex::local
+}  // namespace cortex::local

engine/extensions/local-engine/local_engine.h

@@ -71,4 +71,4 @@ class LocalEngine : public EngineI {
   TaskQueue& q_;
 };
 
-}  // namespace cortex::local
+}  // namespace cortex::local

engine/services/engine_service.cc

@@ -17,6 +17,7 @@
 #include "utils/engine_matcher_utils.h"
 #include "utils/file_manager_utils.h"
 #include "utils/github_release_utils.h"
+#include "utils/hardware/os_info.h"
 #include "utils/logging_utils.h"
 #include "utils/normalize_engine.h"
 #include "utils/result.hpp"
@@ -528,16 +529,59 @@ EngineService::GetEngineVariants(const std::string& engine,
 
   std::vector<EngineVariant> compatible_variants;
   std::vector<github_release_utils::GitHubAsset> assets;
+
+  auto get_os_major = []() -> int {
+    auto os_info = cortex::hw::GetOSInfo();
+    // Get os major version
+    size_t dot_pos = os_info.version.find_first_of(".");
+    if (dot_pos != std::string::npos) {
+      try {
+        return std::stoi(os_info.version.substr(0, dot_pos));
+      } catch (const std::exception& e) {
+        return 0;
+      }
+    } else {
+      // No version found
+      return 0;
+    }
+  };
+
   if (engine_release_menlo.has_value()) {
-    assets.insert(std::end(assets),
-                  std::begin(engine_release_menlo.value().assets),
-                  std::end(engine_release_menlo.value().assets));
+    // In case of macos, if os version is 12, we get binary from menlo
+    std::copy_if(
+        engine_release_menlo.value().assets.begin(),
+        engine_release_menlo.value().assets.end(), std::back_inserter(assets),
+        [get_os_major](const github_release_utils::GitHubAsset& assets) {
+#if defined(__APPLE__) && defined(__MACH__)
+          if (get_os_major() == 12 &&
+              assets.name.find(kMacOs) != std::string::npos) {
+            return true;
+          }
+          return false;
+#else
+          return true;
+#endif
+        });
   }
+  
   if (engine_release_ggml.has_value()) {
-    assets.insert(std::end(assets),
-                  std::begin(engine_release_ggml.value().assets),
-                  std::end(engine_release_ggml.value().assets));
+    // In case of macos, if os version is 12, we get binary from menlo
+    std::copy_if(
+        engine_release_ggml.value().assets.begin(),
+        engine_release_ggml.value().assets.end(), std::back_inserter(assets),
+        [get_os_major](const github_release_utils::GitHubAsset& assets) {
+#if defined(__APPLE__) && defined(__MACH__)
+          if (get_os_major() > 12 &&
+              assets.name.find(kMacOs) != std::string::npos) {
+            return true;
+          }
+          return false;
+#else
+          return true;
+#endif
+        });
   }
+
   for (const auto& variant : assets) {
     CTL_INF("content_type: " << variant.content_type
                              << ", name: " << variant.name);