Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Commit e4e3e90

Browse files
chore: clean default local engines (#1852)
* chore: clean default local engines * chore: e2e tests --------- Co-authored-by: vansangpfiev <sang@jan.ai>
1 parent 68094d9 commit e4e3e90

File tree

4 files changed

+11
-13
lines changed

4 files changed

+11
-13
lines changed

engine/e2e-test/test_cli_engine_get.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,15 @@ def setup_and_teardown(self):
1818
# Teardown
1919
stop_server()
2020

21-
@pytest.mark.skipif(platform.system() != "Windows", reason="Windows-specific test")
21+
@pytest.mark.skipif(reason="Ignore tensorrt-llm test")
2222
def test_engines_get_tensorrt_llm_should_not_be_incompatible(self):
2323
exit_code, output, error = run("Get engine", ["engines", "get", "tensorrt-llm"])
2424
assert exit_code == 0, f"Get engine failed with error: {error}"
2525
assert (
2626
"Incompatible" not in output
2727
), "tensorrt-llm should be Ready or Not Installed on Windows"
2828

29-
@pytest.mark.skipif(platform.system() != "Windows", reason="Windows-specific test")
29+
@pytest.mark.skipif(reason="Ignore onnx-runtime test")
3030
def test_engines_get_onnx_should_not_be_incompatible(self):
3131
exit_code, output, error = run("Get engine", ["engines", "get", "onnxruntime"])
3232
assert exit_code == 0, f"Get engine failed with error: {error}"
@@ -41,23 +41,23 @@ def test_engines_get_llamacpp_should_not_be_incompatible(self):
4141
"Incompatible" not in output
4242
), "llama-cpp should be compatible for Windows, MacOs and Linux"
4343

44-
@pytest.mark.skipif(platform.system() != "Darwin", reason="macOS-specific test")
44+
@pytest.mark.skipif(reason="Ignore tensorrt-llm test")
4545
def test_engines_get_tensorrt_llm_should_be_incompatible_on_macos(self):
4646
exit_code, output, error = run("Get engine", ["engines", "get", "tensorrt-llm"])
4747
assert exit_code == 0, f"Get engine failed with error: {error}"
4848
assert (
4949
"is not supported on" in output
5050
), "tensorrt-llm should be Incompatible on MacOS"
5151

52-
@pytest.mark.skipif(platform.system() != "Darwin", reason="macOS-specific test")
52+
@pytest.mark.skipif(reason="Ignore onnx-runtime test")
5353
def test_engines_get_onnx_should_be_incompatible_on_macos(self):
5454
exit_code, output, error = run("Get engine", ["engines", "get", "onnxruntime"])
5555
assert exit_code == 0, f"Get engine failed with error: {error}"
5656
assert (
5757
"is not supported on" in output
5858
), "onnxruntime should be Incompatible on MacOS"
5959

60-
@pytest.mark.skipif(platform.system() != "Linux", reason="Linux-specific test")
60+
@pytest.mark.skipif(reason="Ignore onnx-runtime test")
6161
def test_engines_get_onnx_should_be_incompatible_on_linux(self):
6262
exit_code, output, error = run("Get engine", ["engines", "get", "onnxruntime"])
6363
print(output)

engine/e2e-test/test_cli_engine_install.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,15 @@ def test_engines_install_llamacpp_should_be_successfully(self):
3131
assert len(response.json()) > 0
3232
assert exit_code == 0, f"Install engine failed with error: {error}"
3333

34-
@pytest.mark.skipif(platform.system() != "Darwin", reason="macOS-specific test")
34+
@pytest.mark.skipif(reason="Ignore onnx-runtime test")
3535
def test_engines_install_onnx_on_macos_should_be_failed(self):
3636
exit_code, output, error = run(
3737
"Install Engine", ["engines", "install", "onnxruntime"]
3838
)
3939
assert "is not supported on" in output, "Should display error message"
4040
assert exit_code == 0, f"Install engine failed with error: {error}"
4141

42-
@pytest.mark.skipif(platform.system() != "Darwin", reason="macOS-specific test")
42+
@pytest.mark.skipif(reason="Ignore tensorrt-llm test")
4343
def test_engines_install_onnx_on_tensorrt_should_be_failed(self):
4444
exit_code, output, error = run(
4545
"Install Engine", ["engines", "install", "tensorrt-llm"]

engine/e2e-test/test_cli_engine_install_nightly.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,15 @@ def test_engines_install_llamacpp_should_be_successfully(self):
3131
assert len(response.json()) > 0
3232
assert exit_code == 0, f"Install engine failed with error: {error}"
3333

34-
@pytest.mark.skipif(platform.system() != "Darwin", reason="macOS-specific test")
34+
@pytest.mark.skipif(reason="Ignore onnx-runtime test")
3535
def test_engines_install_onnx_on_macos_should_be_failed(self):
3636
exit_code, output, error = run(
3737
"Install Engine", ["engines", "install", "onnxruntime"]
3838
)
3939
assert "is not supported on" in output, "Should display error message"
4040
assert exit_code == 0, f"Install engine failed with error: {error}"
4141

42-
@pytest.mark.skipif(platform.system() != "Darwin", reason="macOS-specific test")
42+
@pytest.mark.skipif(reason="Ignore tensorrt-llm test")
4343
def test_engines_install_onnx_on_tensorrt_should_be_failed(self):
4444
exit_code, output, error = run(
4545
"Install Engine", ["engines", "install", "tensorrt-llm"]

engine/utils/config_yaml_utils.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,8 @@ constexpr const auto kDefaultCorsEnabled = true;
2424
const std::vector<std::string> kDefaultEnabledOrigins{
2525
"http://localhost:39281", "http://127.0.0.1:39281", "http://0.0.0.0:39281"};
2626
constexpr const auto kDefaultNoProxy = "example.com,::1,localhost,127.0.0.1";
27-
const std::vector<std::string> kDefaultSupportedEngines{
28-
kLlamaEngine, kOnnxEngine, kTrtLlmEngine, kPythonEngine};
29-
30-
27+
const std::vector<std::string> kDefaultSupportedEngines{kLlamaEngine,
28+
kPythonEngine};
3129

3230
struct CortexConfig {
3331
std::string logFolderPath;

0 commit comments

Comments
 (0)