fix(nitro-node/build): electron got included as dependency

When bundling with rollup, `electron` got included as dependency due to
a transitive dependency, `download@8.0.0` requires `got@^8.3.1`, which
in turn requires `electron` conditionally.

Author: InNoobWeTrust

nitro-node/rollup.config.ts

@@ -13,11 +13,10 @@ export default [
     ],
     // Indicate here external modules you don't wanna include in your bundle (i.e.: 'lodash')
     external: [
-      "electron",
-      "node:fs",
-      "node:child_process",
-      "node:os",
-      "node:path",
+      // `download@8.0.0` requires `got@^8.3.1` which then optionally requires `electron`, result in wrong dependency
+      // Ref: https://github.com/kubernetes-client/javascript/issues/350#issue-500860208
+      // Ref: https://github.com/kubernetes-client/javascript/issues/350#issuecomment-553644659
+      "got",
     ],
     watch: {
       include: "src/**",
@@ -30,15 +29,13 @@ export default [
       // https://github.com/rollup/rollup-plugin-node-resolve#usage
       resolve({
         extensions: [".ts", ".js", ".json"],
-        preferBuiltins: false,
       }),
       // Allow bundling cjs modules (unlike webpack, rollup doesn't understand cjs)
       // This should be after resolve() plugin
       commonjs(),
       // Compile TypeScript files
       typescript({
         useTsconfigDeclarationDir: true,
-        tsconfig: "tsconfig.json",
       }),
 
       // Resolve source maps to the original source
@@ -60,7 +57,12 @@ export default [
       },
     ],
     // Indicate here external modules you don't wanna include in your bundle (i.e.: 'lodash')
-    external: ["electron", "node:fs", "node:path"],
+    external: [
+      // `download@8.0.0` requires `got@^8.3.1` which then optionally requires `electron`, result in wrong dependency
+      // Ref: https://github.com/kubernetes-client/javascript/issues/350#issue-500860208
+      // Ref: https://github.com/kubernetes-client/javascript/issues/350#issuecomment-553644659
+      "got",
+    ],
     watch: {
       include: "src/scripts/**",
     },
@@ -71,18 +73,16 @@ export default [
       // Allow node_modules resolution, so you can use 'external' to control
       // which external modules to include in the bundle
       // https://github.com/rollup/rollup-plugin-node-resolve#usage
-      //resolve({
-      //  extensions: [".ts", ".js", ".json"],
-      //  preferBuiltins: false,
-      //}),
+      resolve({
+        extensions: [".ts", ".js", ".json"],
+      }),
 
       // Allow bundling cjs modules (unlike webpack, rollup doesn't understand cjs)
       // This should be after resolve() plugin
       commonjs(),
       // Compile TypeScript files
       typescript({
-        useTsconfigDeclarationDir: true,
-        tsconfig: "tsconfig.json",
+        useTsconfigDeclarationDir: true
       }),
 
       // Resolve source maps to the original source

nitro-node/tsconfig.json

@@ -6,8 +6,7 @@
     "lib": [
       "es2015",
       "es2016",
-      "es2017",
-      "dom"
+      "es2017"
     ],
     "strict": true,
     "sourceMap": true,