bug: change back to busy waiting to avoid issue on background task

tikikun · tikikun · commit be6ef923e200 · 2024-01-03T16:43:34.000+07:00
diff --git a/controllers/llamaCPP.h b/controllers/llamaCPP.h
@@ -1537,8 +1537,9 @@ struct llama_server_context {
                 "cache\n");
         kv_cache_clear();
       }
-      std::unique_lock<std::mutex> lock(mutex_tasks);
-      condition_tasks.wait(lock, [&] { return !queue_tasks.empty(); });
+      // TODO: Need to implement queueing using CV for better performance
+      // std::unique_lock<std::mutex> lock(mutex_tasks);
+      // condition_tasks.wait(lock, [&] { return !queue_tasks.empty(); });
     }
 
     for (llama_client_slot &slot : slots) {

Original file line number	Diff line number	Diff line change
`@@ -1537,8 +1537,9 @@ struct llama_server_context {`
`1537`	`1537`	`"cache\n");`
`1538`	`1538`	`kv_cache_clear();`
`1539`	`1539`	`}`
`1540`		`- std::unique_lock<std::mutex> lock(mutex_tasks);`
`1541`		`- condition_tasks.wait(lock, [&] { return !queue_tasks.empty(); });`
	`1540`	`+ // TODO: Need to implement queueing using CV for better performance`
	`1541`	`+ // std::unique_lock<std::mutex> lock(mutex_tasks);`
	`1542`	`+ // condition_tasks.wait(lock, [&] { return !queue_tasks.empty(); });`
`1542`	`1543`	`}`
`1543`	`1544`
`1544`	`1545`	`for (llama_client_slot &slot : slots) {`