refactor(nitro-node): nitro release url can be altered upon build

Author: InNoobWeTrust

nitro-node/package.json

@@ -10,7 +10,8 @@
   "scripts": {
     "test": "jest --verbose --detectOpenHandles",
     "build": "tsc --module commonjs && rollup -c rollup.config.ts",
-    "downloadnitro": "tsx src/scripts/download-nitro.ts",
+    "predownloadnitro": "npm run build",
+    "downloadnitro": "node dist/scripts/index.cjs",
     "build:publish": "npm pack",
     "postinstall": "node -r @janhq/nitro-node/postinstall"
   },
@@ -43,6 +44,7 @@
     "@rollup/plugin-commonjs": "^25.0.7",
     "@rollup/plugin-json": "^6.1.0",
     "@rollup/plugin-node-resolve": "^15.2.3",
+    "@rollup/plugin-replace": "^5.0.5",
     "@types/download": "^8.0.5",
     "@types/jest": "^29.5.11",
     "@types/node": "^20.11.4",
@@ -54,7 +56,6 @@
     "rollup-plugin-typescript2": "^0.36.0",
     "ts-jest": "^29.1.2",
     "ts-node": "^10.9.2",
-    "tsx": "^4.7.0",
     "typescript": "^5.3.3"
   },
   "dependencies": {

nitro-node/rollup.config.ts

@@ -3,6 +3,7 @@ import commonjs from "@rollup/plugin-commonjs";
 import sourceMaps from "rollup-plugin-sourcemaps";
 import typescript from "rollup-plugin-typescript2";
 import json from "@rollup/plugin-json";
+import replace from "@rollup/plugin-replace";
 
 export default [
   {
@@ -67,6 +68,14 @@ export default [
       include: "src/scripts/**",
     },
     plugins: [
+      replace({
+        RELEASE_URL_PREFIX: JSON.stringify(
+          "https://api.github.com/repos/janhq/nitro/releases/",
+        ),
+        TAGGED_RELEASE_URL_PREFIX: JSON.stringify(
+          "https://api.github.com/repos/janhq/nitro/releases/tags",
+        ),
+      }),
       // Allow json resolution
       json(),
 
@@ -82,7 +91,7 @@ export default [
       commonjs(),
       // Compile TypeScript files
       typescript({
-        useTsconfigDeclarationDir: true
+        useTsconfigDeclarationDir: true,
       }),
 
       // Resolve source maps to the original source

nitro-node/src/scripts/download-nitro.ts

@@ -10,17 +10,12 @@ const PLATFORM = process.env.npm_config_platform || process.platform;
 // The platform architecture
 //const ARCH = process.env.npm_config_arch || process.arch;
 
-const releaseUrlPrefixVariants = {
-  latest: "https://api.github.com/repos/janhq/nitro/releases/",
-  tag: "https://api.github.com/repos/janhq/nitro/releases/tags/",
-};
-
 const getReleaseInfo = async (taggedVersion: string): Promise<any> => {
   const releaseUrlPrefix =
     taggedVersion === "latest"
-      ? releaseUrlPrefixVariants.latest
+      ? RELEASE_URL_PREFIX
       : taggedVersion.match(/^v?\d+\.\d+\.\d+$/gi)
-        ? releaseUrlPrefixVariants.tag
+        ? TAGGED_RELEASE_URL_PREFIX
         : undefined;
   if (!releaseUrlPrefix) throw Error(`Invalid version: ${taggedVersion}`);
   const url = `${releaseUrlPrefix}${taggedVersion}`;
@@ -59,17 +54,19 @@ const extractDownloadInfo = async (
   suffixVariants: Record<string, string>,
 ): Promise<Record<string, { url: string; dir: string }>> => {
   console.log(`[Release URL][prerelease=${prerelease}] ${html_url}`);
-  const assetNames = assets.map(({ name }: { name: string }) => name);
   const assetsToDownloads = Object.entries(suffixVariants).reduce(
     (
       dict: Record<string, { url: string; dir: string }>,
       [suffix, dir]: [string, string],
     ) => {
+      const assetInfo = assets.find(
+        (a) => a.name === `nitro-${name}-${suffix}.tar.gz`,
+      );
       // Skip if suffix is not in asset names
-      if (!assetNames.includes(`nitro-${name}-${suffix}.tar.gz`)) return dict;
+      if (!assetInfo) return dict;
       // Else add the download url
       dict[suffix] = {
-        url: `https://github.com/janhq/nitro/releases/download/${tag_name}/nitro-${name}-${suffix}.tar.gz`,
+        url: assetInfo.browser_download_url,
         dir,
       };
       return dict;

nitro-node/src/scripts/types/global.d.ts

@@ -0,0 +1,4 @@
+// These constants are defined in `rollup.config.ts` at the root of the repository
+// In plugin `replace`, you can change the URL to a different fork if you must
+declare const RELEASE_URL_PREFIX: string;
+declare const TAGGED_RELEASE_URL_PREFIX: string;