fix: windows e2e tests

Author: vansangpfiev

engine/extensions/local-engine/local_engine.cc

@@ -5,6 +5,7 @@
 #include "utils/curl_utils.h"
 #include "utils/json_helper.h"
 #include "utils/logging_utils.h"
+#include "utils/process/utils.h"
 #include "utils/url_parser.h"
 
 namespace cortex::local {
@@ -548,11 +549,7 @@ void LocalEngine::LoadModel(std::shared_ptr<Json::Value> json_body,
   auto log_path =
       (file_manager_utils::GetCortexLogPath() / "logs" / "cortex.log").string();
   CTL_DBG("log: " << log_path);
-  CTL_INF("exe path: "
-          << file_manager_utils::GetExecutableFolderContainerPath().string());
-  auto result = cortex::process::SpawnProcess(
-      v, log_path, log_path,
-      file_manager_utils::GetExecutableFolderContainerPath().string());
+  auto result = cortex::process::SpawnProcess(v, log_path, log_path);
   if (result.has_error()) {
     CTL_ERR("Fail to spawn process. " << result.error());
     Json::Value error;

engine/services/engine_service.cc

@@ -329,6 +329,24 @@ cpp::result<void, std::string> EngineService::DownloadEngine(
                                        std::filesystem::perms::others_exec,
                                    std::filesystem::perm_options::add);
 
+      const std::vector<std::string> windows_deps = {
+          "msvcp140.dll", "vcruntime140.dll", "vcruntime140_1.dll"};
+      for (auto const& win_dep : windows_deps) {
+        if (std::filesystem::exists(
+                file_manager_utils::GetExecutableFolderContainerPath() /
+                win_dep)) {
+          CTL_INF("Copy file "
+                  << (file_manager_utils::GetExecutableFolderContainerPath() /
+                      win_dep)
+                         .string()
+                  << " to " << extract_path.string());
+          std::filesystem::copy_file(
+              file_manager_utils::GetExecutableFolderContainerPath() / win_dep,
+              extract_path / win_dep,
+              std::filesystem::copy_options::overwrite_existing);
+        }
+      }
+
     } catch (const std::exception& e) {
       CTL_INF(e.what());
     }
@@ -563,7 +581,7 @@ EngineService::GetEngineVariants(const std::string& engine,
 #endif
         });
   }
-  
+
   if (engine_release_ggml.has_value()) {
     // In case of macos, if os version is 12, we get binary from menlo
     std::copy_if(

engine/utils/process/utils.cc

@@ -42,7 +42,7 @@ std::vector<char*> ConvertToArgv(const std::vector<std::string>& args) {
 
 cpp::result<ProcessInfo, std::string> SpawnProcess(
     const std::vector<std::string>& command, const std::string& stdout_file,
-    const std::string& stderr_file, const std::string& current_directory) {
+    const std::string& stderr_file) {
   std::stringstream ss;
   for (const auto& item : command) {
     ss << item << " ";
@@ -109,21 +109,17 @@ cpp::result<ProcessInfo, std::string> SpawnProcess(
 
     // create a suspended process. we will resume it later after adding it to
     // a job (see below)
-    if (!CreateProcessA(
-            NULL,              // lpApplicationName
-            command_buffer,    // lpCommandLine
-            NULL,              // lpProcessAttributes
-            NULL,              // lpThreadAttributes
-            TRUE,              // bInheritHandles
-            CREATE_SUSPENDED,  // dwCreationFlags
-            NULL,              // lpEnvironment
-            current_directory.empty()
-                ? NULL
-                : const_cast<char*>(
-                      current_directory.c_str()),  // lpCurrentDirectory
-            &si,                                   // lpStartupInfo
-            &pi                                    // lpProcessInformation
-            )) {
+    if (!CreateProcessA(NULL,              // lpApplicationName
+                        command_buffer,    // lpCommandLine
+                        NULL,              // lpProcessAttributes
+                        NULL,              // lpThreadAttributes
+                        TRUE,              // bInheritHandles
+                        CREATE_SUSPENDED,  // dwCreationFlags
+                        NULL,              // lpEnvironment
+                        NULL,              // lpCurrentDirectory
+                        &si,               // lpStartupInfo
+                        &pi                // lpProcessInformation
+                        )) {
       if (hStdOut != NULL)
         CloseHandle(hStdOut);
       if (hStdErr != NULL)

engine/utils/process/utils.h

@@ -36,8 +36,7 @@ std::vector<char*> ConvertToArgv(const std::vector<std::string>& args);
 
 cpp::result<ProcessInfo, std::string> SpawnProcess(
     const std::vector<std::string>& command,
-    const std::string& stdout_file = "", const std::string& stderr_file = "",
-    const std::string& current_directory = "");
+    const std::string& stdout_file = "", const std::string& stderr_file = "");
 bool IsProcessAlive(ProcessInfo& proc_info);
 bool WaitProcess(ProcessInfo& proc_info);
 bool KillProcess(ProcessInfo& proc_info);