Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Commit 3bf5f87

Browse files
authored
Merge pull request #1687 from janhq/j/update-user-defined-engine-path
fix: support user defined engine path
2 parents 11aaf19 + 481a092 commit 3bf5f87

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

engine/services/engine_service.cc

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -773,26 +773,29 @@ cpp::result<void, std::string> EngineService::LoadEngine(
773773
auto selected_engine_variant = GetDefaultEngineVariant(ne);
774774

775775
if (selected_engine_variant.has_error()) {
776-
// TODO: namh need to fallback
777776
return cpp::fail(selected_engine_variant.error());
778777
}
779778

780779
CTL_INF("Selected engine variant: "
781780
<< json_helper::DumpJsonString(selected_engine_variant->ToJson()));
782781

783782
auto user_defined_engine_path = getenv("ENGINE_PATH");
783+
CTL_DBG("user defined engine path: " << user_defined_engine_path);
784784
const std::filesystem::path engine_dir_path = [&] {
785785
if (user_defined_engine_path != nullptr) {
786-
// for backward compatible
787786
return std::filesystem::path(user_defined_engine_path +
788-
GetEnginePath(ne));
787+
GetEnginePath(ne)) /
788+
selected_engine_variant->variant /
789+
selected_engine_variant->version;
789790
} else {
790791
return file_manager_utils::GetEnginesContainerPath() / ne /
791792
selected_engine_variant->variant /
792793
selected_engine_variant->version;
793794
}
794795
}();
795796

797+
CTL_DBG("Engine path: " << engine_dir_path.string());
798+
796799
if (!std::filesystem::exists(engine_dir_path)) {
797800
CTL_ERR("Directory " + engine_dir_path.string() + " is not exist!");
798801
return cpp::fail("Directory " + engine_dir_path.string() +

0 commit comments

Comments
 (0)