Skip to content

Commit 2eaf53a

Browse files
authored
Merge pull request #10 from jamdotdev/aidan/fix-types-more
fix types
2 parents 3c41b91 + d2bc0fe commit 2eaf53a

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/types.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ export interface NodeWorker {
55
terminate(): void;
66
}
77

8+
// `SharedWorker` is not `WorkerLike`, because it must be messaged through a port
89
export type WorkerLike = Worker | NodeWorker;
910

1011
export enum events {
@@ -68,9 +69,9 @@ export interface RPCResolvePayload {
6869

6970
export type GuestConnectOptions = {
7071
hostTarget?: Target;
71-
onConnectionSetup: (remote: Schema) => Promise<void>;
72+
onConnectionSetup?: (remote: Schema) => Promise<void>;
7273
};
7374

74-
export type Guest = WorkerLike | HTMLIFrameElement;
75+
export type Guest = WorkerLike | HTMLIFrameElement | SharedWorker;
7576
export type Target = Window | WorkerLike | MessagePort;
7677
export type Environment = Window | WorkerLike | MessagePort;

0 commit comments

Comments
 (0)