Cannot compile with --all-features

[GideonBear]

Causing failing docs.rs builds since 0.43.0: https://docs.rs/crate/self_update/latest/builds/2988266
Ref #168

It fails with:

error[E0659]: `get` is ambiguous
   --> src/backends/s3.rs:606:29
    |
606 |     let resp = http_client::get(&api_url, Default::default())?;
    |                             ^^^ ambiguous name
    |
    = note: ambiguous because of multiple glob imports of a name in the same module

[GideonBear]

Bisected to 7f6052d (unsuprisingly)

[andrewdavidmackenzie]

Same issue with 0.43.1, as I use "cargo clippy --all-features" in my app that uses it, and that also is broken.

[GideonBear]

Features are supposed to be additive so maybe it was a bad idea to implement ureq/reqwest this way anyway. I don't have enough experience to know how to solve this, if anyone wants to chime in that's appreciated; otherwise I will take a look at how other crates solve this later.

[andrewdavidmackenzie]

I'll take a look and see if I can help in any way

[andrewdavidmackenzie]

OK, looking closer - I take it all back :-)

My particular issue is that I tend to use default-features = false on all dependencies "by default", to keep build times and code size to a minimum.

That disables the request feature and the crate won't build.

I can work around this easily, but you could consider having a config that would build with all features turned off.

But it's not really what you want to do in this case, which is chose a particular backend, between two options.
(I wish features could take values and not just be on/off)

I have seen other crates do this for similar reasons.

They sometimes make it clearer by having a compile_error!() macro invocation with an explanation, behind a #[cfg] when neither backend (reqwest or ureq) is enabled, making it clearer to dependants that they need to chose one and no features is invalid?

[GideonBear]

That's a separate problem for me though, #168.
--all-features not working because of the conflict between the two is something else than --no-default features not working because of the necessity of one of the two.

I'm wondering whether the solution should just be to change the docs-rs config to not pass --all-features, and acknowledge that --all-features doesn't work? Again I'll want to look at other crates to see if that's common.

[andrewdavidmackenzie]

You could kind of hard-code in the "request" functionality as it was before, you can put it behind a #[cfg(not(features = "ureq")], and avoid the reqwest feature completely.

all features would include ureq and switch in that backend

no features would leave the reqwest functionality.

BTW: I use cargo all-features plugin to check combinations when it gets complicated, but here I think making it simpler would be better

[GideonBear]

docs.rs build failing should be resolved by #174 when that gets released. We need to check then.
And still, I consider this to be a problem (just maybe a little less urgent)