Skip to content

Commit c08809b

Browse files
committed
docs: remove ACP migration references now that REST backend is complete
1 parent 5b4b633 commit c08809b

File tree

5 files changed

+12
-15
lines changed

5 files changed

+12
-15
lines changed

.memory/SUMMARY.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
- **Frontend**: React 19 + Vite + TypeScript
1010
- **Backend**: Tauri 2 (Rust)
11-
- **Protocol**: Migrating from ACP (JSON-RPC over stdio) to REST API (`opencode serve`)
11+
- **Protocol**: REST API (`opencode serve` — HTTP + SSE)
1212

1313
## Architecture Invariants
1414

@@ -28,7 +28,7 @@
2828

2929
## Current Focus
3030

31-
- REST API migration (from `opencode acp` to `opencode serve`)
31+
- REST backend polish and parity
3232
- Thread lifecycle and event handling polish
3333
- Token usage tracking and session management
3434

AGENTS.md

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ Detailed navigation/runbooks live in:
99

1010
- `docs/codebase-map.md` (task-oriented file map: "if you need X, edit Y")
1111
- `README.md` (setup, build, release, and broader project docs)
12-
- `docs/shaping/rest-api-migration.md` (architecture decision: ACP to REST API migration)
12+
- `docs/shaping/rest-api-migration.md` (REST backend architecture and parity status)
1313

1414
## Project Purpose
1515

@@ -29,17 +29,15 @@ We pull upstream CodexMonitor changes regularly (weekly/monthly). The fork's tra
2929

3030
The frontend thread reducer receives events in the **same shape** as original CodexMonitor. All OpenCode-to-CodexMonitor translation happens in Rust, never in the frontend.
3131

32-
### Backend: Migrating from ACP to REST API
32+
### Backend: REST API
3333

34-
The backend is migrating from `opencode acp` (JSON-RPC over stdio) to `opencode serve` (HTTP REST + SSE). See `docs/shaping/rest-api-migration.md` for the full rationale, requirements, and implementation slices.
35-
36-
The migration touches three files — the same three already diverged from upstream:
34+
The backend uses `opencode serve` (HTTP REST + SSE). The translation layer is isolated to three Rust files so frontend merges stay clean:
3735

3836
- `src-tauri/src/backend/event_translator.rs` — protocol events to CodexMonitor event shapes
3937
- `src-tauri/src/shared/codex_core.rs` — all protocol methods
4038
- `src-tauri/src/backend/app_server.rs` — process spawn, event routing
4139

42-
Internal Rust module paths (`codex_core.rs`, `codex/mod.rs`, etc.) are **not renamed** — only user-facing strings. This minimizes merge conflicts with upstream.
40+
Internal Rust module paths (`codex_core.rs`, `codex/mod.rs`, etc.) are **not renamed** — only user-facing strings. This minimizes merge conflicts with upstream. (The original CodexMonitor used Codex CLI; this fork uses OpenCode REST instead.)
4341

4442
## Non-Negotiable Architecture Rules
4543

@@ -178,7 +176,7 @@ Use extra care in high-churn/high-complexity files:
178176

179177
- Task-oriented code map: `docs/codebase-map.md`
180178
- Setup/build/release/test commands: `README.md`
181-
- Architecture decision (ACP to REST migration): `docs/shaping/rest-api-migration.md`
179+
- REST backend architecture: `docs/shaping/rest-api-migration.md`
182180
- Frontend event contract: `docs/app-server-events.md`
183181
- For OpenCode API/feature changes, refer to `opencode-server-api.mdx` and `./tmp/opencode` before implementing protocol or behavior updates.
184182

src-tauri/src/backend/app_server.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,7 @@ mod urlencoding {
407407
}
408408

409409
// ---------------------------------------------------------------------------
410-
// PATH env and command building (unchanged from ACP)
410+
// PATH env and command building
411411
// ---------------------------------------------------------------------------
412412

413413
pub(crate) fn build_codex_path_env(codex_bin: Option<&str>) -> Option<String> {

src-tauri/src/shared/codex_core.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -903,16 +903,15 @@ pub(crate) async fn set_thread_name_core(
903903
}
904904

905905
// ---------------------------------------------------------------------------
906-
// Image handling (kept from ACP — same logic)
906+
// Image handling
907907
// ---------------------------------------------------------------------------
908908

909909
const URL_IMAGE_FETCH_TIMEOUT: Duration = Duration::from_secs(10);
910910
const URL_IMAGE_MAX_BYTES: usize = 8 * 1024 * 1024;
911911

912912
/// Build REST prompt parts from frontend input.
913913
///
914-
/// REST uses `{ type: "file", mime, url: "data:...", filename }` for images
915-
/// instead of ACP's `{ type: "image", mimeType, data }`.
914+
/// REST uses `{ type: "file", mime, url: "data:...", filename }` for images.
916915
async fn build_rest_prompt_parts(
917916
text: String,
918917
images: Option<Vec<String>>,

src/features/settings/components/sections/SettingsCodexSection.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ export function SettingsCodexSection({
327327
</button>
328328
</div>
329329
<div className="settings-help">
330-
Extra flags passed before <code>acp</code>. Use quotes for values with spaces.
330+
Extra flags passed to <code>serve</code>. Use quotes for values with spaces.
331331
</div>
332332
<div className="settings-help">
333333
OpenCode server:{" "}
@@ -415,7 +415,7 @@ export function SettingsCodexSection({
415415
</div>
416416
<div className="settings-doctor-body">
417417
<div>Version: {doctorState.result.version ?? "unknown"}</div>
418-
<div>ACP command: {doctorState.result.appServerOk ? "ok" : "failed"}</div>
418+
<div>Server: {doctorState.result.appServerOk ? "ok" : "failed"}</div>
419419
<div>
420420
Node:{" "}
421421
{doctorState.result.nodeOk

0 commit comments

Comments
 (0)