Skip to content

excessive calls to glObjectLabel etc #2356

@Trass3r

Description

@Trass3r

glObjectLabel is being called for every update in setVertexAttrib instead of just once right after creation:

if (vb.getName() != null) glext.glObjectLabel(GLExt.GL_BUFFER, vb.getId(), vb.getName());

This actually shows up in RenderDoc and in a CPU usage profile.
Also vb.getName() never returns null.

Also if not done right after creation it's easy to miss something, e.g. index buffers are never set cause of

public void setVertexAttrib(VertexBuffer vb, VertexBuffer idb) {
if (vb.getBufferType() == VertexBuffer.Type.Index) {
throw new IllegalArgumentException("Index buffers not allowed to be set to vertex attrib");

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

Status

No status

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions