-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Open
Description
glObjectLabel is being called for every update in setVertexAttrib instead of just once right after creation:
| if (vb.getName() != null) glext.glObjectLabel(GLExt.GL_BUFFER, vb.getId(), vb.getName()); |
This actually shows up in RenderDoc and in a CPU usage profile.
Also vb.getName() never returns null.
Also if not done right after creation it's easy to miss something, e.g. index buffers are never set cause of
jmonkeyengine/jme3-core/src/main/java/com/jme3/renderer/opengl/GLRenderer.java
Lines 3116 to 3118 in 03c26a8
| public void setVertexAttrib(VertexBuffer vb, VertexBuffer idb) { | |
| if (vb.getBufferType() == VertexBuffer.Type.Index) { | |
| throw new IllegalArgumentException("Index buffers not allowed to be set to vertex attrib"); |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
No status