Consider removing ZipAlign.alignZip(InputStream, ..)

[MohammedKHC]

There are a few reasons that make me thing it should be completely removed.

1. It's just too slow.
2. Removing it will also remove com.macfaq.io.LittleEndianInputStream, and com.macfaq.io.LittleEndianOutputStream
3. Removing it decreases the line count of ZipAlign.java by around 220 lines. And thus making the project easier to maintain

BTW, this is just a suggestion. So feel free to do what you want @iyxan23!

[iyxan23]

Yes! I agree with it very much :)

I plan on getting rid of the InputStream API, but I am waiting to do it on v2.0.0, since getting rid of it would mean a breaking change, we'd need to do it in a new major version.

But I'm also looking for adding some actually new features, and perhaps making the library able to be used without necessarily a RandomAccessFile or an OutputStream. Because removing the InputStream API would mean people couldn't use a memory-stored zip anymore, the library would then only work on files opened with RandomAccessFile. This idea (and some extensions of it) are laid out in #7.

Let me know if you have any ideas!

[MohammedKHC]

Hmm in my opinion just removing alignZip(InputStream, ..) is enough.

I think that the ZipAlign class is not that big, so it will be better if it stays that way. But this is just a personal opinion.

Also java == OOP. So just do what you and it will be fine.

BTW I think that no one ever does use zipalign for an in memory zip.
That's because it's mostly used to align the apk generated by aapt. And aapt does create a file..
However you can make the ZipAlign take a regular File and then convert it to RandomAccessFile automatically.

Thanks for your time!