Skip to content

Commit 54a9b47

Browse files
authored
Merge pull request #89 from rettinghaus/fix/warnings
Fix warnings
2 parents bb0b3fc + df980aa commit 54a9b47

File tree

4 files changed

+32
-31
lines changed

4 files changed

+32
-31
lines changed

edtf/parser/grammar.py

Lines changed: 28 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77
from edtf.appsettings import DEBUG_PYPARSING
88
from edtf.util import remapparams
99

10-
pyparsing.ParserElement.enablePackrat()
11-
10+
pyparsing.ParserElement.enable_packrat()
1211
from pyparsing import (
1312
Combine,
1413
NotAny,
@@ -20,7 +19,7 @@
2019
Word,
2120
ZeroOrMore,
2221
nums,
23-
oneOf,
22+
one_of,
2423
)
2524
from pyparsing import Literal as L
2625

@@ -50,18 +49,18 @@
5049
Unspecified,
5150
)
5251

53-
oneThru12 = oneOf([f"{i:02}" for i in range(1, 13)])
54-
oneThru13 = oneOf([f"{i:02}" for i in range(1, 14)])
55-
oneThru23 = oneOf([f"{i:02}" for i in range(1, 24)])
56-
zeroThru23 = oneOf([f"{i:02}" for i in range(0, 24)])
57-
oneThru29 = oneOf([f"{i:02}" for i in range(1, 30)])
58-
oneThru30 = oneOf([f"{i:02}" for i in range(1, 31)])
59-
oneThru31 = oneOf([f"{i:02}" for i in range(1, 32)])
60-
oneThru59 = oneOf([f"{i:02}" for i in range(1, 60)])
61-
zeroThru59 = oneOf([f"{i:02}" for i in range(0, 60)])
52+
oneThru12 = one_of([f"{i:02}" for i in range(1, 13)])
53+
oneThru13 = one_of([f"{i:02}" for i in range(1, 14)])
54+
oneThru23 = one_of([f"{i:02}" for i in range(1, 24)])
55+
zeroThru23 = one_of([f"{i:02}" for i in range(0, 24)])
56+
oneThru29 = one_of([f"{i:02}" for i in range(1, 30)])
57+
oneThru30 = one_of([f"{i:02}" for i in range(1, 31)])
58+
oneThru31 = one_of([f"{i:02}" for i in range(1, 32)])
59+
oneThru59 = one_of([f"{i:02}" for i in range(1, 60)])
60+
zeroThru59 = one_of([f"{i:02}" for i in range(0, 60)])
6261

6362
digit = Word(nums, exact=1)
64-
positiveDigit = Word(nums, exact=1, excludeChars="0")
63+
positiveDigit = Word(nums, exact=1, exclude_chars="0")
6564
positiveInteger = Combine(positiveDigit + ZeroOrMore(digit))
6665

6766
second = zeroThru59
@@ -71,8 +70,8 @@
7170

7271
month = oneThru12("month")
7372
monthDay = (
74-
(oneOf("01 03 05 07 08 10 12")("month") + "-" + oneThru31("day"))
75-
^ (oneOf("04 06 09 11")("month") + "-" + oneThru30("day"))
73+
(one_of("01 03 05 07 08 10 12")("month") + "-" + oneThru31("day"))
74+
^ (one_of("04 06 09 11")("month") + "-" + oneThru30("day"))
7675
^ (L("02")("month") + "-" + oneThru29("day"))
7776
)
7877

@@ -95,15 +94,15 @@
9594
date = Combine(year ^ yearMonth ^ yearMonthDay)("date")
9695
Date.set_parser(date)
9796

98-
zoneOffsetHour = oneThru13
99-
zoneOffset = L("Z") ^ (
97+
zone_offsetHour = oneThru13
98+
zone_offset = L("Z") ^ (
10099
Regex("[+-]")
101-
+ (zoneOffsetHour + Optional(":" + minute) ^ L("14:00") ^ ("00:" + oneThru59))
100+
+ (zone_offsetHour + Optional(":" + minute) ^ L("14:00") ^ ("00:" + oneThru59))
102101
)
103102

104103
baseTime = Combine(hour + ":" + minute + ":" + second ^ "24:00:00")
105104

106-
time = Combine(baseTime + Optional(zoneOffset))("time")
105+
time = Combine(baseTime + Optional(zone_offset))("time")
107106

108107
dateAndTime = date + "T" + time
109108
DateAndTime.set_parser(dateAndTime)
@@ -117,10 +116,10 @@
117116
# (* ************************** Level 1 *************************** *)
118117

119118
# (* ** Auxiliary Assignments for Level 1 ** *)
120-
UASymbol = Combine(oneOf("? ~ %"))
119+
UASymbol = Combine(one_of("? ~ %"))
121120
UA.set_parser(UASymbol)
122121

123-
seasonNumber = oneOf("21 22 23 24")
122+
seasonNumber = one_of("21 22 23 24")
124123

125124
# (* *** Season (unqualified) *** *)
126125
season = year + "-" + seasonNumber("season")
@@ -153,9 +152,9 @@ def f(toks):
153152

154153

155154
l1Start = ".." ^ uaDateOrSeason
156-
l1Start.addParseAction(f)
155+
l1Start.add_parse_action(f)
157156
l1End = uaDateOrSeason ^ ".."
158-
l1End.addParseAction(f)
157+
l1End.add_parse_action(f)
159158

160159
level1Interval = Optional(l1Start)("lower") + "/" + l1End("upper") ^ l1Start(
161160
"lower"
@@ -197,7 +196,7 @@ def f(toks):
197196
dayWithX = Combine(("X" + digitOrX) ^ (digitOrX + "X"))("day")
198197

199198
# 2-digit month with at least one 'X' present
200-
monthWithX = Combine(oneOf("0X 1X") ^ ("X" + digitOrX))("month")
199+
monthWithX = Combine(one_of("0X 1X") ^ ("X" + digitOrX))("month")
201200

202201
# 4-digit year with at least one 'X' present
203202
yearWithX = Combine(
@@ -301,8 +300,8 @@ def f(toks):
301300
^ consecutives
302301
)
303302

304-
earlier = L("..").addParseAction(f)("lower") + date("upper").addParseAction(f)
305-
later = date("lower").addParseAction(f) + L("..").addParseAction(f)("upper")
303+
earlier = L("..").add_parse_action(f)("lower") + date("upper").add_parse_action(f)
304+
later = date("lower").add_parse_action(f) + L("..").add_parse_action(f)("upper")
306305

307306
EarlierConsecutives.set_parser(earlier)
308307
LaterConsecutives.set_parser(later)
@@ -323,7 +322,9 @@ def f(toks):
323322

324323

325324
# (* *** L2 Season *** *)
326-
seasonL2Number = oneOf("21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41")
325+
seasonL2Number = one_of(
326+
"21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41"
327+
)
327328
l2season = year + "-" + seasonL2Number("season")
328329
Level2Season.set_parser(l2season)
329330

edtf/parser/parser_classes.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ class EDTFObject:
104104
@classmethod
105105
def set_parser(cls, p):
106106
cls.parser = p
107-
p.addParseAction(cls.parse_action)
107+
p.add_parse_action(cls.parse_action)
108108

109109
@classmethod
110110
def parse_action(cls, toks):
@@ -117,7 +117,7 @@ def parse_action(cls, toks):
117117

118118
@classmethod
119119
def parse(cls, s):
120-
return cls.parser.parseString(s)[0]
120+
return cls.parser.parse_string(s)[0]
121121

122122
def __repr__(self) -> str:
123123
return f"{type(self).__name__}: '{str(self)}'"

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ license = { file = "LICENSE" }
55
keywords = ['edtf']
66
dependencies = [
77
"python-dateutil",
8-
"pyparsing",
8+
"pyparsing>=3.0.0",
99
]
1010
description = "Python implementation of Library of Congress EDTF (Extended Date Time Format) specification"
1111
requires-python = ">=3.10"

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
python-dateutil
2-
pyparsing
2+
pyparsing >= 3.0.0

0 commit comments

Comments
 (0)