From cab95073e35d452fe6b8976fb68c139f4f2a019c Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Tue, 17 Mar 2026 20:07:49 +0000
Subject: [PATCH 1/2] Initial plan


From 0c9b6903fc5de16df3efd5e47cd2607b434401f2 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Tue, 17 Mar 2026 20:16:19 +0000
Subject: [PATCH 2/2] Add nullable boolean attribute to column type

Co-authored-by: pahjbo <273267+pahjbo@users.noreply.github.com>
---
 src/main/resources/tap2VOSI.xsl      |  7 ++++++-
 src/main/vo-dml/tapschema.vo-dml.xml | 12 ++++++++++++
 src/main/vodsl/tapschema.vodsl       |  1 +
 3 files changed, 19 insertions(+), 1 deletion(-)

diff --git a/src/main/resources/tap2VOSI.xsl b/src/main/resources/tap2VOSI.xsl
index d04da60..838b27e 100644
--- a/src/main/resources/tap2VOSI.xsl
+++ b/src/main/resources/tap2VOSI.xsl
@@ -38,7 +38,7 @@
    </xsl:template>
     <xsl:template match="table/columns/column">
         <column>
-            <xsl:apply-templates select="(column_name,description,unit,ucd,utype,datatype,indexed,principal)"/>
+            <xsl:apply-templates select="(column_name,description,unit,ucd,utype,datatype,indexed,principal,nullable)"/>
         </column>
     </xsl:template>
     <xsl:template match="indexed">
@@ -47,6 +47,11 @@
     <xsl:template match="principal">
         <flag>primary</flag>
     </xsl:template>
+    <xsl:template match="nullable[text()='true']">
+        <flag>nullable</flag>
+    </xsl:template>
+    <!-- suppress output for nullable=false -->
+    <xsl:template match="nullable"/>
     <xsl:template match="datatype">
         <xsl:element name="dataType" >
             <xsl:attribute name="type" namespace="http://www.w3.org/2001/XMLSchema-instance">vs:VOTableType</xsl:attribute>
diff --git a/src/main/vo-dml/tapschema.vo-dml.xml b/src/main/vo-dml/tapschema.vo-dml.xml
index dfad6f0..940066b 100644
--- a/src/main/vo-dml/tapschema.vo-dml.xml
+++ b/src/main/vo-dml/tapschema.vo-dml.xml
@@ -431,6 +431,18 @@
                    <maxOccurs>1</maxOccurs>
                  </multiplicity>
                </attribute>
+               <attribute>
+                 <vodml-id>column.nullable</vodml-id>
+                 <name>nullable</name>
+                 <description>indicates whether the column may have null values</description>	    
+                 <datatype>
+                    <vodml-ref>ivoa:boolean</vodml-ref>
+                 </datatype>
+                 <multiplicity>
+                   <minOccurs>0</minOccurs>
+                   <maxOccurs>1</maxOccurs>
+                 </multiplicity>
+               </attribute>
                <attribute>
                  <vodml-id>column.column_index</vodml-id>
                  <name>column_index</name>
diff --git a/src/main/vodsl/tapschema.vodsl b/src/main/vodsl/tapschema.vodsl
index f73fb52..7514a7c 100644
--- a/src/main/vodsl/tapschema.vodsl
+++ b/src/main/vodsl/tapschema.vodsl
@@ -69,6 +69,7 @@ query. In cases where the service selects the columns to return (such as a
 query language without an explicit output selection), the principal column
 indicates those columns that are returned by default";
 	std: ivoa:boolean "is the column defined by a standard";
+	nullable: ivoa:boolean @? "indicates whether the column may have null values";
 	column_index: ivoa:integer @? "used to recommend table ordering for clients. Clients
 may order by index (ascending) so lower index items would appear
 earlier in a listing.";