Skip to content

Commit 2668ae2

Browse files
committed
Merge branch 'hotfix/1.8.5'
2 parents 373254f + afdb565 commit 2668ae2

6 files changed

Lines changed: 99 additions & 152 deletions

File tree

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## [Unreleased]
99

10+
## [1.8.5] - 2025-02-14
11+
12+
- Change to `composer/semver` to fix advisories mapping
13+
1014
## [1.8.4] - 2025-02-14
1115

1216
- Fix server edit/create bug

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
"ext-ctype": "*",
99
"ext-iconv": "*",
1010
"api-platform/core": "^4.0",
11+
"composer/semver": "^3.4",
1112
"doctrine/dbal": "^4.0",
1213
"doctrine/doctrine-bundle": "^2.13",
1314
"doctrine/doctrine-migrations-bundle": "^3.4",
@@ -40,8 +41,7 @@
4041
"symfony/uid": "^7.2",
4142
"symfony/validator": "^7.2",
4243
"symfony/webpack-encore-bundle": "^2.0",
43-
"symfony/yaml": "^7.2",
44-
"z4kn4fein/php-semver": "^3.0"
44+
"symfony/yaml": "^7.2"
4545
},
4646
"require-dev": {
4747
"ergebnis/composer-normalize": "^2.23",

composer.lock

Lines changed: 82 additions & 136 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docker-compose.server.override.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,9 @@ services:
2727
- "host.docker.internal:host-gateway"
2828
volumes:
2929
- .:/app
30-
- ../../shared/.env.local:/app/.env.local
3130
depends_on:
3231
- rabbit
3332

3433
phpfpm:
35-
volumes:
36-
- ../../shared/.env.local:/app/.env.local
3734
depends_on:
3835
- rabbit

docker-compose.server.prod.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
services:
2+
supervisor:
3+
volumes:
4+
- ../../shared/.env.local:/app/.env.local
5+
6+
phpfpm:
7+
volumes:
8+
- ../../shared/.env.local:/app/.env.local

src/Service/AdvisoryFactory.php

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,8 @@
99
use App\Entity\Package;
1010
use App\Entity\PackageVersion;
1111
use App\Repository\AdvisoryRepository;
12+
use Composer\Semver\Semver;
1213
use Doctrine\ORM\EntityManagerInterface;
13-
use z4kn4fein\SemVer\Constraints\Constraint;
14-
use z4kn4fein\SemVer\SemverException;
15-
use z4kn4fein\SemVer\Version;
1614

1715
class AdvisoryFactory
1816
{
@@ -91,14 +89,8 @@ private function getInstalledPackageVersion(Installation $installation, string $
9189
private function setAdvisoryForAffectedVersions(Package $package, Advisory $advisory): void
9290
{
9391
foreach ($package->getPackageVersions() as $packageVersion) {
94-
try {
95-
$constraint = Constraint::parse($advisory->getAffectedVersions());
96-
$version = Version::parse($packageVersion->getVersion(), false);
97-
if ($constraint->isSatisfiedBy($version)) {
98-
$advisory->addPackageVersion($packageVersion);
99-
}
100-
} catch (SemverException) {
101-
// Ignore
92+
if (Semver::satisfies($packageVersion->getVersion(), $advisory->getAffectedVersions())) {
93+
$advisory->addPackageVersion($packageVersion);
10294
}
10395
}
10496
}

0 commit comments

Comments
 (0)