Question about the code of evaluation on the whole sequence

[xherdan76]

Hi,
I wonder whether there is an issue with the code for evaluating on the whole sequence. The input of the model as well as gt_pos is the position of the fluid at current time step. After the model forwards, the new pr_pos should be the position of the next time step. However, in Line 233, the errors are still computed between pr_pos and gt_pos, which are not aligned in time.

Is my understanding wrong or it's a bug with the code?

DeepLagrangianFluids/scripts/evaluate_network.py

Lines 221 to 226 in d651c6f

	init_pos = torch.from_numpy(data['pos0'][0]).to(device)
	init_vel = torch.from_numpy(data['vel0'][0]).to(device)
	inputs = (init_pos, init_vel, None, box, box_normals)
	else:
	inputs = (pr_pos, pr_vel, None, box, box_normals)

DeepLagrangianFluids/scripts/evaluate_network.py

Lines 232 to 238 in d651c6f

	gt_pos = data['pos0'][0]
	fluid_errors.add_errors(scene_id,
	0,
	frame_id,
	scale * pr_pos.cpu().numpy(),
	scale * gt_pos,
	compute_gt2pred_distance=True)

[WangLeft]

Hi!
I also encountered the same issue when evaluating the model. Have you managed to resolve it? It appears that there could be an alignment problem between pr_pos and gt_pos in terms of time.