These functions are bad:
static void Fail(Error& error, EIOErrorCode code, const char* file, int line);
static void Fail(Error& error, std::ios& status, const char* file, int line);
They only fail if there is an actual error but the name doesn't say that. Also they should indicate whether the error was set or not.
Also needs to be reviewed and see if it fits in the error scheme redesign.
These functions are bad:
static void Fail(Error& error, EIOErrorCode code, const char* file, int line);
static void Fail(Error& error, std::ios& status, const char* file, int line);
They only fail if there is an actual error but the name doesn't say that. Also they should indicate whether the error was set or not.
Also needs to be reviewed and see if it fits in the error scheme redesign.