Skip to content

Enable accessibility warnings on Ada#2168

Open
sjd210 wants to merge 7 commits into
mainfrom
improvement/accessibility-icons-on-ada
Open

Enable accessibility warnings on Ada#2168
sjd210 wants to merge 7 commits into
mainfrom
improvement/accessibility-icons-on-ada

Conversation

@sjd210
Copy link
Copy Markdown
Contributor

@sjd210 sjd210 commented May 22, 2026

  • Adds icon to accessibility warning banner on Ada (since there is no question metadata box to otherwise display the icon in)
  • Enables accessibility icons as a content property tag for Ada question ALVIs
  • Fixes bug with useDeviceSize on Ada, which is currently calculating size as if ALL pages have sidebars. This now only applies to the pages under the My Ada branch (relevant here because this was causing the ALVI titles to wrap too early)

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.68%. Comparing base (00d56f9) to head (bfb634b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ts/navigation/InaccessibleContentWarningBanner.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2168   +/-   ##
=======================================
  Coverage   43.68%   43.68%           
=======================================
  Files         594      594           
  Lines       25043    25046    +3     
  Branches     7425     7425           
=======================================
+ Hits        10940    10942    +2     
- Misses      14054    14056    +2     
+ Partials       49       48    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sjd210 sjd210 marked this pull request as ready for review May 22, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant