Skip to content

[irods/irods#7984] Document rebalance with partial success, commands to query replicas#424

Open
MartinFlores751 wants to merge 1 commit into
irods:mainfrom
MartinFlores751:irods_7984.m
Open

[irods/irods#7984] Document rebalance with partial success, commands to query replicas#424
MartinFlores751 wants to merge 1 commit into
irods:mainfrom
MartinFlores751:irods_7984.m

Conversation

@MartinFlores751
Copy link
Copy Markdown
Contributor

Issue quick link: irods/irods#7984

This PR documents the new rebalance error from PR irods/irods#8930, along with queries to get data objects that could not be replicated.

Copy link
Copy Markdown
Contributor Author

@MartinFlores751 MartinFlores751 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments that come to mind.


To get the number of data objects with replicas which are not marked "good":
```
SELECT COUNT(DATA_COLL_ID) WHERE DATA_REPL_STATUS != '1'
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if DATA_ID is more appropriate here, or if DATA_COLL_ID is what is best...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think DATA_ID is correct - that will match which data objects have non-good replicas...

DATA_COLL_ID will be the COLL_ID of the parent of the data objects in question... so I don't think that's right.

Comment on lines +482 to +487
To find all data objects with replicas which are not marked "good":
```
SELECT COLL_NAME, DATA_NAME WHERE DATA_REPL_STATUS != '1'
```

To get the number of data objects with replicas which are not marked "good":
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing the quotations around good. That is the proper name of the replica status: https://docs.irods.org/5.0.2/system_overview/data_objects/#replica-status

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the quotes are okay - or perhaps you're looking to make them backticks which makes it look like a literal or codename?

I think backticks could be more correct... please look around and compare to other places where we talk about replica statuses.


When a rebalance completes successfully, the timestamp AVU is removed.

If the rebalance operation encounters data objects that cannot be replicated, due to being stale or locked, a `-1834000 REBALANCE_NOT_COMPLETE` message will be displayed and a non-zero exit code is returned after replicating all remaining good data objects. Afterwards, the unreplicated data objects must be handled manually if replication is still desired.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what non-zero error code? can we know and be explicit here?

Comment on lines +482 to +487
To find all data objects with replicas which are not marked "good":
```
SELECT COLL_NAME, DATA_NAME WHERE DATA_REPL_STATUS != '1'
```

To get the number of data objects with replicas which are not marked "good":
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the quotes are okay - or perhaps you're looking to make them backticks which makes it look like a literal or codename?

I think backticks could be more correct... please look around and compare to other places where we talk about replica statuses.


To get the number of data objects with replicas which are not marked "good":
```
SELECT COUNT(DATA_COLL_ID) WHERE DATA_REPL_STATUS != '1'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think DATA_ID is correct - that will match which data objects have non-good replicas...

DATA_COLL_ID will be the COLL_ID of the parent of the data objects in question... so I don't think that's right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants