Skip to content

Commit 0eec39d

Browse files
committed
Make curve keys private and typed
1 parent 8a2a911 commit 0eec39d

1 file changed

Lines changed: 8 additions & 5 deletions

File tree

ipykernel/heartbeat.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ def __init__(self, context, addr=None, *, curve_publickey=None, curve_secretkey=
4848
self.context = context
4949
self.transport, self.ip, self.port = addr
5050
self.original_port = self.port
51-
self.curve_publickey = curve_publickey
52-
self.curve_secretkey = curve_secretkey
51+
self._curve_publickey = curve_publickey
52+
self._curve_secretkey = curve_secretkey
5353
if self.original_port == 0:
5454
self.pick_port()
5555
self.addr = (self.ip, self.port)
@@ -109,9 +109,9 @@ def run(self):
109109
self.name = "Heartbeat"
110110
self.socket = self.context.socket(zmq.ROUTER)
111111
self.socket.linger = 1000
112-
if self.curve_secretkey is not None:
113-
self.socket.curve_secretkey = self.curve_secretkey
114-
self.socket.curve_publickey = self.curve_publickey
112+
if self._curve_secretkey is not None:
113+
self.socket.curve_secretkey = self._curve_secretkey
114+
self.socket.curve_publickey = self._curve_publickey
115115
self.socket.curve_server = True
116116
try:
117117
self._bind_socket()
@@ -141,3 +141,6 @@ def run(self):
141141
raise
142142
else:
143143
break
144+
145+
_curve_publickey: bytes | None
146+
_curve_secretkey: bytes | None

0 commit comments

Comments
 (0)