Given the amount of interest in updating commands-lib commands to the latest commands-lib version (and the recently fixed bugs in MakeTypedEncoder), let's have a meta-issue.
General suggestions:
- Prefer
MakeTypedEncoder, it removes some boilerplate.
- Old encoders tended to return
NewReader(someByteBufferOrString). In new code, prefer writing directly to the provided writer instead of first building up a temporary buffer/string.
Please comment below with the commands you're planning on fixing (just that).
They'll be checked off when actually fixed.
Given the amount of interest in updating commands-lib commands to the latest commands-lib version (and the recently fixed bugs in MakeTypedEncoder), let's have a meta-issue.
General suggestions:
MakeTypedEncoder, it removes some boilerplate.NewReader(someByteBufferOrString). In new code, prefer writing directly to the provided writer instead of first building up a temporary buffer/string.Please comment below with the commands you're planning on fixing (just that).
They'll be checked off when actually fixed.
lscommand #5611 commands/ls: use new cmds lib #5663