Small validation fixes

Author: Kubinyete

src/Domain/Address/ShippingAddress.php

@@ -41,6 +41,6 @@ public function __construct(
 
     protected function assertValidShippingCost(): void
     {
-        DomainException::assert(is_null($this->shipping_cost) || $this->shipping_cost >= 0, "Shipping cost can be null or greater than 0.");
+        DomainException::assert(is_null($this->shipping_cost) || $this->shipping_cost >= 0, "Shipping cost can be null or greater or equal to 0.");
     }
 }

src/Domain/Order/Card.php

@@ -25,7 +25,7 @@ public function __construct(
         $this->expiry_month = substr(trim($expiry_month), 0, 2);
         $this->expiry_year = substr(trim($expiry_year), 0, 4);
 
-        $this->assertValidHolder();
+        // $this->assertValidHolder();
         $this->assertValidNumber();
         $this->assertValidExpiryMonth();
         $this->assertValidExpiryYear();
@@ -38,8 +38,8 @@ protected function assertValidHolder(): void
 
     protected function assertValidNumber(): void
     {
-        DomainException::assert(preg_match('/^[0-9]{13,19}$/', $this->number), "Card number should only contain digits with length between 13 and 19 characters.");
-        DomainException::assert(Luhn::check($this->number), "Number is not a valid credit card number.");
+        DomainException::assert(preg_match('/^[0-9\\*]{13,19}$/', $this->number), "Card number should only contain digits with length between 13 and 19 characters.");
+        // DomainException::assert(Luhn::check($this->number), "Number is not a valid credit card number.");
     }
 
     protected function assertValidExpiryMonth(): void

src/Domain/Order/Customer.php

@@ -19,7 +19,7 @@ class Customer implements JsonSerializable
     protected Document $document;
     protected ?Gender $gender;
     protected ?DateTime $birth_date;
-    protected Email $email;
+    protected ?Email $email;
     protected ?MobilePhone $mobile_phone;
     protected ?FixedLinePhone $phone;
 
@@ -29,7 +29,7 @@ public function __construct(
         Document $document,
         ?Gender $gender,
         ?DateTime $birth_date,
-        Email $email,
+        ?Email $email,
         ?MobilePhone $mobile_phone,
         ?FixedLinePhone $phone
     ) {
@@ -80,7 +80,7 @@ public function jsonSerialize()
             'document' => $this->document->jsonSerialize(),
             'gender' => $this->gender ? (string)$this->gender : null,
             'birth_date' => $this->birth_date ? $this->birth_date->format('Y-m-d') : null,
-            'email' => (string)$this->email,
+            'email' => $this->email ? (string)$this->email : null,
             'mobile_phone' => $this->mobile_phone ? (string)$this->mobile_phone : null,
             'phone' => $this->phone ? (string)$this->phone : null,
         ];

src/Domain/Order/Item.php

@@ -11,30 +11,30 @@ class Item implements JsonSerializable
     protected string $name;
     protected float $unit_price;
     protected int $quantity;
-    protected string $sku;
+    protected ?string $sku;
     protected ?string $description;
 
     public function __construct(
         ?string $merchant_item_id,
         string $name,
         float $unit_price,
         int $quantity,
-        string $sku,
+        ?string $sku,
         ?string $description
     ) {
         $this->merchant_item_id = $merchant_item_id ? substr(trim($merchant_item_id), 0, 255) : $merchant_item_id;
         $this->name = substr(trim($name), 0, 64);
         $this->unit_price = $unit_price;
         $this->quantity = $quantity;
-        $this->sku = substr(trim($sku), 0, 12);
+        $this->sku = $sku ? substr(trim($sku), 0, 12) : $sku;
         $this->description = $description ? substr(trim($description), 0, 128) : $description;
 
         $this->assertValidMerchantItemId();
         $this->assertValidName();
         $this->assertValidUnitPrice();
         $this->assertValidQuantity();
-        $this->assertValidSku();
-        $this->assertValidDescription();
+        // $this->assertValidSku();
+        // $this->assertValidDescription();
     }
 
     protected function assertValidMerchantItemId(): void

src/Domain/Order/Order.php

@@ -13,6 +13,7 @@ class Order implements JsonSerializable
     protected string $merchant_order_id;
     protected float $amount;
     protected int $installments;
+    protected bool $is_recurring;
     protected CurrencyCode $currency;
     protected Customer $customer;
     protected BillingAddress $billing_address;
@@ -34,11 +35,13 @@ public function __construct(
         Factor $factors,
         array $items = [],
         array $payments = [],
-        array $metadata = []
+        array $metadata = [],
+        bool $is_recurring = false
     ) {
         $this->merchant_order_id = $merchant_order_id;
         $this->amount = $amount;
         $this->installments = $installments;
+        $this->is_recurring = $is_recurring;
         $this->currency = $currency;
         $this->customer = $customer;
         $this->billing_address = $billing_address;
@@ -52,7 +55,7 @@ public function __construct(
 
         $this->assertValidAmount();
         $this->assertValidInstallments();
-        $this->assertValidMerchantOrderId();
+        // $this->assertValidMerchantOrderId();
     }
 
     protected function assertValidAmount(): void
@@ -103,6 +106,7 @@ public function jsonSerialize()
             'merchant_order_id' => $this->merchant_order_id,
             'amount' => $this->amount,
             'installments' => $this->installments,
+            'is_recurring' => $this->is_recurring,
             'currency' => (string)$this->currency,
             'status' => (string)$this->status,
             'customer' => $this->customer->jsonSerialize(),

src/Domain/Order/PaymentMethod.php

@@ -21,10 +21,15 @@ class PaymentMethod implements Stringable
     public const VISAELECTRON = 'visaelectron';
     public const MAESTRO = 'maestro';
     public const ELODEBIT = 'elodebit';
+
+    public const CREDIT_CARD = 'creditcard';
+    public const DEBIT_CARD = 'debitcard';
     public const PIX = 'pix';
     public const BILLET = 'billet';
 
     public const ALLOWED = [
+        self::CREDIT_CARD,
+        self::DEBIT_CARD,
         self::VISA,
         self::MASTERCARD,
         self::ELO,
@@ -123,6 +128,15 @@ public static function billet(): self
         return new static(self::BILLET);
     }
 
+    public static function creditCard(): self
+    {
+        return new static(self::CREDIT_CARD);
+    }
+
+    public static function debitCard(): self
+    {
+        return new static(self::DEBIT_CARD);
+    }
 
     public function __toString(): string
     {