You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looks like we closed #229 a bit too early. We now have ReconnectingSocket, which accepts a reconnectedHandler. However, this handler is never used.
What we need for iov-one/ponferrada#14 is clients that keep track of subsciptions they have. As soon as the socket reconnects, those subscriptions need to be recreated. This affects WebsocketClient from the Tendermint package and WsEthereumRpcClient.
This is needed for the browser extension to track transaction state after postTx. For Ethereum we use polling in this case, so this is lower priority. But in case of BNS, we use both transaction and block subscriptions in postTx, so this is needed for iov-one/ponferrada#14.
Use reconnectedHandler in Tendermint (this ticket)
Looks like we closed #229 a bit too early. We now have
ReconnectingSocket, which accepts areconnectedHandler. However, this handler is never used.What we need for iov-one/ponferrada#14 is clients that keep track of subsciptions they have. As soon as the socket reconnects, those subscriptions need to be recreated. This affects
WebsocketClientfrom the Tendermint package andWsEthereumRpcClient.This is needed for the browser extension to track transaction state after
postTx. For Ethereum we use polling in this case, so this is lower priority. But in case of BNS, we use both transaction and block subscriptions inpostTx, so this is needed for iov-one/ponferrada#14.