From 037286b589812d173f7b861498465f76be2169cd Mon Sep 17 00:00:00 2001 From: Alexandre Jacinto Date: Thu, 26 Mar 2026 16:28:29 -0400 Subject: [PATCH 1/3] feat(RMET-5076): remove unused error codes from IONCAMRError Removes NO_IMAGE_SELECTED_ERROR, GET_IMAGE_ERROR, PERMISSION_DENIED_ERROR, UNABLE_TO_ACCESS_GALLERY_ERROR, FILE_NOT_FOUND_OR_INACCESSIBLE_ERROR, FAILED_TO_SAVE_FILE_ERROR, and RESOURCE_BUSY_ERROR as they are no longer used. --- .../io/ionic/libs/ioncameralib/model/IONCAMRError.kt | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/main/kotlin/io/ionic/libs/ioncameralib/model/IONCAMRError.kt b/src/main/kotlin/io/ionic/libs/ioncameralib/model/IONCAMRError.kt index 08ee732..c5a97c7 100644 --- a/src/main/kotlin/io/ionic/libs/ioncameralib/model/IONCAMRError.kt +++ b/src/main/kotlin/io/ionic/libs/ioncameralib/model/IONCAMRError.kt @@ -2,13 +2,11 @@ package io.ionic.libs.ioncameralib.model enum class IONCAMRError(val code: Int, val description: String) { CAMERA_PERMISSION_DENIED_ERROR(3, "Couldn't access camera. Check your camera permissions and try again."), - NO_IMAGE_SELECTED_ERROR(5, "No image selected."), GALLERY_PERMISSION_DENIED_ERROR(6, "Couldn't access your photo gallery because access wasn't provided."), NO_PICTURE_TAKEN_ERROR(7, "No picture captured."), NO_CAMERA_AVAILABLE_ERROR(8, "No camera available."), EDIT_IMAGE_ERROR (10, "Couldn't edit image."), TAKE_PHOTO_ERROR(11, "Couldn't capture picture."), - GET_IMAGE_ERROR(12, "Couldn't get image from the gallery."), PROCESS_IMAGE_ERROR(13, "Couldn't process image."), EDIT_CANCELLED_ERROR(14, "Couldn't edit picture because the process was canceled."), CAPTURE_VIDEO_ERROR(18, "Couldn't capture video."), @@ -20,16 +18,10 @@ enum class IONCAMRError(val code: Int, val description: String) { EDIT_PICTURE_EMPTY_URI_ERROR(27, "URI parameter cannot be empty."), FILE_DOES_NOT_EXIST_ERROR(30, "The selected file doesn't exist."), FETCH_IMAGE_FROM_URI_ERROR(31, "Couldn't retrieve image from the URI."), - PERMISSION_DENIED_ERROR(35, "Permission denied."), FAILED_TO_CAPTURE_IMAGE_ERROR(36, "Failed to capture image."), - UNABLE_TO_ACCESS_GALLERY_ERROR(37, "Unable to access photo gallery."), VIDEO_CAPTURE_NOT_SUPPORTED_ERROR(38, "Video capture not supported."), - FILE_NOT_FOUND_OR_INACCESSIBLE_ERROR(39, "File not found or inaccessible."), EDIT_OPERATION_CANCELLED_ERROR(40, "User canceled the edit operation."), INVALID_ARGUMENT_ERROR(41, "Invalid argument provided to plugin method."), - FAILED_TO_SAVE_FILE_ERROR(42, "Failed to save file."), - RESOURCE_BUSY_ERROR(43, "Camera or other device resource is busy."), - // Overall Android specific CONTEXT_ERROR(202, "Unable to get the context.") From 4fc7e37c9dcd7a2b2f46c4e08a448523d96d3825 Mon Sep 17 00:00:00 2001 From: Alexandre Jacinto Date: Thu, 26 Mar 2026 17:24:30 -0400 Subject: [PATCH 2/3] refactor: remove and update errors --- .../io/ionic/libs/ioncameralib/model/IONCAMRError.kt | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/main/kotlin/io/ionic/libs/ioncameralib/model/IONCAMRError.kt b/src/main/kotlin/io/ionic/libs/ioncameralib/model/IONCAMRError.kt index c5a97c7..60c53c0 100644 --- a/src/main/kotlin/io/ionic/libs/ioncameralib/model/IONCAMRError.kt +++ b/src/main/kotlin/io/ionic/libs/ioncameralib/model/IONCAMRError.kt @@ -3,14 +3,14 @@ package io.ionic.libs.ioncameralib.model enum class IONCAMRError(val code: Int, val description: String) { CAMERA_PERMISSION_DENIED_ERROR(3, "Couldn't access camera. Check your camera permissions and try again."), GALLERY_PERMISSION_DENIED_ERROR(6, "Couldn't access your photo gallery because access wasn't provided."), - NO_PICTURE_TAKEN_ERROR(7, "No picture captured."), + NO_PICTURE_TAKEN_ERROR(7, "Couldn't take photo because the process was canceled."), NO_CAMERA_AVAILABLE_ERROR(8, "No camera available."), EDIT_IMAGE_ERROR (10, "Couldn't edit image."), - TAKE_PHOTO_ERROR(11, "Couldn't capture picture."), + TAKE_PHOTO_ERROR(11, "Couldn't take photo."), PROCESS_IMAGE_ERROR(13, "Couldn't process image."), - EDIT_CANCELLED_ERROR(14, "Couldn't edit picture because the process was canceled."), - CAPTURE_VIDEO_ERROR(18, "Couldn't capture video."), - CAPTURE_VIDEO_CANCELLED_ERROR(19, "Couldn't capture video because the process was canceled."), + EDIT_CANCELLED_ERROR(14, "Couldn't edit photo because the process was canceled."), + CAPTURE_VIDEO_ERROR(18, "Couldn't record video."), + CAPTURE_VIDEO_CANCELLED_ERROR(19, "Couldn't record video because the process was canceled."), GENERIC_CHOOSE_MULTIMEDIA_ERROR(21, "Couldn't choose media from the gallery."), CHOOSE_MULTIMEDIA_CANCELLED_ERROR(23, "Couldn't choose media from the gallery because the process was canceled."), MEDIA_PATH_ERROR(24, "Couldn't get media file path."), @@ -20,7 +20,6 @@ enum class IONCAMRError(val code: Int, val description: String) { FETCH_IMAGE_FROM_URI_ERROR(31, "Couldn't retrieve image from the URI."), FAILED_TO_CAPTURE_IMAGE_ERROR(36, "Failed to capture image."), VIDEO_CAPTURE_NOT_SUPPORTED_ERROR(38, "Video capture not supported."), - EDIT_OPERATION_CANCELLED_ERROR(40, "User canceled the edit operation."), INVALID_ARGUMENT_ERROR(41, "Invalid argument provided to plugin method."), // Overall Android specific From bc7b81c005e1f26dabf596f74839631fe66333bd Mon Sep 17 00:00:00 2001 From: Alexandre Jacinto Date: Fri, 27 Mar 2026 09:37:35 -0400 Subject: [PATCH 3/3] chore: update error codes --- .../libs/ioncameralib/model/IONCAMRError.kt | 38 +++++++++---------- 1 file changed, 18 insertions(+), 20 deletions(-) diff --git a/src/main/kotlin/io/ionic/libs/ioncameralib/model/IONCAMRError.kt b/src/main/kotlin/io/ionic/libs/ioncameralib/model/IONCAMRError.kt index 60c53c0..c861097 100644 --- a/src/main/kotlin/io/ionic/libs/ioncameralib/model/IONCAMRError.kt +++ b/src/main/kotlin/io/ionic/libs/ioncameralib/model/IONCAMRError.kt @@ -2,26 +2,24 @@ package io.ionic.libs.ioncameralib.model enum class IONCAMRError(val code: Int, val description: String) { CAMERA_PERMISSION_DENIED_ERROR(3, "Couldn't access camera. Check your camera permissions and try again."), - GALLERY_PERMISSION_DENIED_ERROR(6, "Couldn't access your photo gallery because access wasn't provided."), - NO_PICTURE_TAKEN_ERROR(7, "Couldn't take photo because the process was canceled."), - NO_CAMERA_AVAILABLE_ERROR(8, "No camera available."), - EDIT_IMAGE_ERROR (10, "Couldn't edit image."), - TAKE_PHOTO_ERROR(11, "Couldn't take photo."), - PROCESS_IMAGE_ERROR(13, "Couldn't process image."), - EDIT_CANCELLED_ERROR(14, "Couldn't edit photo because the process was canceled."), - CAPTURE_VIDEO_ERROR(18, "Couldn't record video."), - CAPTURE_VIDEO_CANCELLED_ERROR(19, "Couldn't record video because the process was canceled."), - GENERIC_CHOOSE_MULTIMEDIA_ERROR(21, "Couldn't choose media from the gallery."), - CHOOSE_MULTIMEDIA_CANCELLED_ERROR(23, "Couldn't choose media from the gallery because the process was canceled."), - MEDIA_PATH_ERROR(24, "Couldn't get media file path."), - PLAY_VIDEO_GENERAL_ERROR(26, "Couldn't play video."), - EDIT_PICTURE_EMPTY_URI_ERROR(27, "URI parameter cannot be empty."), - FILE_DOES_NOT_EXIST_ERROR(30, "The selected file doesn't exist."), - FETCH_IMAGE_FROM_URI_ERROR(31, "Couldn't retrieve image from the URI."), - FAILED_TO_CAPTURE_IMAGE_ERROR(36, "Failed to capture image."), - VIDEO_CAPTURE_NOT_SUPPORTED_ERROR(38, "Video capture not supported."), - INVALID_ARGUMENT_ERROR(41, "Invalid argument provided to plugin method."), + GALLERY_PERMISSION_DENIED_ERROR(5, "Couldn't access your photo gallery because access wasn't provided."), + NO_PICTURE_TAKEN_ERROR(6, "Couldn't take photo because the process was canceled."), + NO_CAMERA_AVAILABLE_ERROR(7, "No camera available."), + EDIT_IMAGE_ERROR (9, "Couldn't edit image."), + TAKE_PHOTO_ERROR(10, "Couldn't take photo."), + PROCESS_IMAGE_ERROR(12, "Couldn't process image."), + EDIT_CANCELLED_ERROR(13, "Couldn't edit photo because the process was canceled."), + CAPTURE_VIDEO_ERROR(16, "Couldn't record video."), + CAPTURE_VIDEO_CANCELLED_ERROR(17, "Couldn't record video because the process was canceled."), + GENERIC_CHOOSE_MULTIMEDIA_ERROR(19, "Couldn't choose media from the gallery."), + CHOOSE_MULTIMEDIA_CANCELLED_ERROR(21, "Couldn't choose media from the gallery because the process was canceled."), + MEDIA_PATH_ERROR(22, "Couldn't get media file path."), + PLAY_VIDEO_GENERAL_ERROR(24, "Couldn't play video."), + EDIT_PICTURE_EMPTY_URI_ERROR(25, "URI parameter cannot be empty."), + FILE_DOES_NOT_EXIST_ERROR(28, "The selected file doesn't exist."), + FETCH_IMAGE_FROM_URI_ERROR(29, "Couldn't retrieve image from the URI."), + INVALID_ARGUMENT_ERROR(32, "Invalid argument provided to plugin method."), // Overall Android specific - CONTEXT_ERROR(202, "Unable to get the context.") + CONTEXT_ERROR(34, "Unable to get the context.") } \ No newline at end of file