The isolate-check-environment script assumes the command isolate is available in $PATH for its cgroup check when it runs isolate to figure out the cgroup root on https://github.com/ioi/isolate/blob/master/isolate-check-environment#L118 . Running isolate-check-environment when isolate is not in the path gives a misleading warning, "cgroup root not found. isolate --cg cannot be used."
This is basically a non-issue with the default configuration where the install goes in /usr/bin. We recently moved where we install isolate and ran into this, so I figured I'd open an issue. Completely understandable if you feel this is a wontfix - we've worked around it, I doubt many will ever be affected, and the fix doesn't feel super clean.
Options I see for fixing:
- Run
$(dirname $0)/isolate, assuming the script is in the same directory as the binary (which is what we did for our workaround)
- Hard code a full path to the executable based on
BINDIR via Makefile
- Check
command -v isolate and give a different error message (or fall back to one of the methods above) when isolate isn't in path.
The
isolate-check-environmentscript assumes the commandisolateis available in$PATHfor its cgroup check when it runsisolateto figure out the cgroup root on https://github.com/ioi/isolate/blob/master/isolate-check-environment#L118 . Runningisolate-check-environmentwhenisolateis not in the path gives a misleading warning, "cgroup root not found. isolate --cg cannot be used."This is basically a non-issue with the default configuration where the install goes in
/usr/bin. We recently moved where we installisolateand ran into this, so I figured I'd open an issue. Completely understandable if you feel this is a wontfix - we've worked around it, I doubt many will ever be affected, and the fix doesn't feel super clean.Options I see for fixing:
$(dirname $0)/isolate, assuming the script is in the same directory as the binary (which is what we did for our workaround)BINDIRviaMakefilecommand -v isolateand give a different error message (or fall back to one of the methods above) whenisolateisn't in path.