Skip to content

Commit 7cd39c6

Browse files
author
Salvi
committed
Comments on missing equals methods
1 parent cf39a74 commit 7cd39c6

3 files changed

Lines changed: 3 additions & 0 deletions

File tree

src/main/kotlin/it/intre/code/database/reader/sql/ComparisonFilterBuilder.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import org.apache.commons.lang3.StringUtils
55
import org.apache.commons.lang3.StringUtils.isBlank
66
import org.apache.commons.lang3.StringUtils.wrap
77

8+
//FIXME implement equals and hashCode using fields: filter, asString, name
89
class ComparisonFilterBuilder internal constructor(override val filter: ComparisonFilter, name: String) : SqlFilterBuilder(name) {
910
private val asString: Boolean
1011

src/main/kotlin/it/intre/code/database/reader/sql/SqlFilterBuilder.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import java.util.Collections.emptyList
1313
* To manage a new filter type: extend this class,
1414
* implement abstract methods and add new implementation to factory method.
1515
*/
16+
//FIXME implement equals and hashCode using fields: name
1617
abstract class SqlFilterBuilder(val name: String) {
1718

1819
internal abstract val filter: GenericFilter

src/main/kotlin/it/intre/code/database/reader/sql/TextFilterBuilder.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import java.lang.String.format
99
/**
1010
* SQL builder for filters of type text, matching on "=" or "LIKE"
1111
*/
12+
//FIXME implement equals and hashCode using fields: filter, name
1213
internal class TextFilterBuilder(override val filter: TextFilter, name: String) : SqlFilterBuilder(name) {
1314

1415
override val orConditions: List<String>

0 commit comments

Comments
 (0)