update to messages

Author: detain

.claude/skills/add-test-fixture/SKILL.md

@@ -6,77 +6,54 @@ description: Creates a new test event fixture directory under tests/events/{even
 
 ## Critical
 
-- Every fixture directory requires **three files** — `GithubMessageBuilderTest.php` reads all three; missing any will cause a fatal test error:
+- Every fixture directory requires **exactly three files** — `GithubMessageBuilderTest.php` skips any directory missing `expected_text.txt`. The required files are:
   ```
   tests/events/deployment/type.txt
   tests/events/deployment/payload.json
   tests/events/deployment/expected_text.txt
   ```
-- `expected_text.txt` contains plain-text chat message output — **generate it by running the test harness**, not by hand.
-- The value in `tests/events/deployment/type.txt` must match the `X-GitHub-Event` header value exactly (e.g. `push`, `pull_request`, `ping`) — no trailing newline issues; the test trims it.
+- `expected_text.txt` contains **plain text** (no IRC color codes). Write the expected `$Msg['text']` output from `GithubMessageBuilder::build()` directly.
+- Do NOT create `expected.bin` or `discord.json` — those are for the removed `IrcConverter`/`DiscordConverter` and will be silently ignored.
+- The value in `type.txt` must match the `X-GitHub-Event` header value exactly (e.g. `push`, `pull_request`) — `GithubMessageBuilderTest.php` trims it.
 
 ## Instructions
 
 1. **Create the fixture directory.**
-   Use the GitHub event name as the directory name (e.g. `deployment`, `workflow_dispatch`). For action variants, append `_{action}` (e.g. `pull_request_merged`, `issue_closed`). Verify no existing directory with that name exists under `tests/events/`.
+   ```bash
+   mkdir tests/events/deployment
+   ```
+   Use the GitHub event name as the directory name. For action variants, append `_{action}` (e.g. `pull_request_merged`, `issues_closed`).
 
 2. **Write the event type file.**
-   Content is the bare event type only — no action suffix, no newline required (the test trims it). Matches the value GitHub sends in the `X-GitHub-Event` HTTP header.
-   Write `deployment` to `tests/events/deployment/type.txt`.
+   ```bash
+   echo -n 'deployment' > tests/events/deployment/type.txt
+   ```
+   Bare event type only — no action suffix, no trailing newline required.
 
 3. **Write the payload file.**
-   Save a real GitHub webhook payload to `tests/events/deployment/payload.json`. Mirror the formatting of existing fixtures — tabs for indentation, `JSON_PRETTY_PRINT | JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES` style:
-   ```json
-   {
-   	"action": "created",
-   	"sender": {
-   		"login": "octocat",
-   		"id": 1,
-   		"avatar_url": "https:\/\/avatars.githubusercontent.com\/u\/1?v=3"
-   	},
-   	"repository": {
-   		"id": 1296269,
-   		"name": "Hello-World",
-   		"full_name": "octocat\/Hello-World",
-   		"html_url": "https:\/\/github.com\/octocat\/Hello-World",
-   		"private": false
-   	}
-   }
-   ```
-   Verify `tests/events/deployment/payload.json` is valid JSON:
+   Copy a real payload from `log/` (structure is `{"repo":"...","event":"...","data":{...}}`; use the `data` value) or from GitHub docs. Save as `tests/events/deployment/payload.json`. Validate:
    ```bash
    php -r "json_decode(file_get_contents('tests/events/deployment/payload.json')); echo json_last_error();"
    ```
    Must print `0`.
 
-4. **Generate `expected_text.txt` using the test suite.**
-   Run the tests — the new fixture will fail and print the actual output. Use that output as the content of `expected_text.txt`, then re-run to confirm it passes:
-   ```bash
-   vendor/bin/phpunit tests/GithubMessageBuilderTest.php
+4. **Determine the expected text.**
+   Instantiate `GithubMessageBuilder` with the event type and payload, call `build()['text']`, and save the result:
+   ```php
+   $builder = new GithubMessageBuilder('deployment', json_decode(file_get_contents('tests/events/deployment/payload.json'), true));
+   echo $builder->build()['text'];
    ```
+   Or generate it via a quick CLI script and write to `tests/events/deployment/expected_text.txt`.
 
 5. **Verify the fixture passes.**
    ```bash
-   vendor/bin/phpunit tests/GithubMessageBuilderTest.php
+   vendor/bin/phpunit
    ```
-   All tests must pass.
-
-## Examples
-
-**User says:** "Add a test fixture for the `deployment` event"
-
-**Actions taken:**
-1. Create `tests/events/deployment/`
-2. Write `tests/events/deployment/type.txt` → `deployment`
-3. Write `tests/events/deployment/payload.json` with a real GitHub deployment payload
-4. Run `vendor/bin/phpunit tests/GithubMessageBuilderTest.php`, capture actual output, write to `tests/events/deployment/expected_text.txt`
-5. Re-run tests to verify they pass
-
-**Result:** `tests/events/deployment/` contains all three files; `vendor/bin/phpunit tests/GithubMessageBuilderTest.php` exits green.
+   All tests must pass. The fixture is picked up automatically via `DirectoryIterator` on `tests/events/`.
 
 ## Common Issues
 
-- **`file_get_contents(...): Failed to open stream`** — one of the three required files is missing. Check `tests/events/deployment/` contains `type.txt`, `payload.json`, `expected_text.txt`.
-- **`assertEquals failed`** — `expected_text.txt` content doesn't match actual output. Re-run the test, capture actual output, update the file.
-- **New fixture not picked up by test runner** — confirm the directory is directly under `tests/events/` (not nested). The test uses a single-level `DirectoryIterator`.
-- **`GetEventType()` assertion fails** — `tests/events/deployment/type.txt` contains extra whitespace or wrong casing. The value must exactly match the GitHub `X-GitHub-Event` header (all lowercase, underscores, e.g. `pull_request` not `Pull-Request`).
+- **Fixture not tested** — `expected_text.txt` is missing. The test provider skips directories without this file.
+- **`assertSame` fails with whitespace difference** — `expected_text.txt` has a trailing newline. The test `trim()`s the file content, so trailing newlines are fine, but mid-string differences (e.g. extra space) will fail.
+- **`json_decode` returns null** — `payload.json` has invalid JSON. Validate with `php -r "var_dump(json_decode(file_get_contents('...')));"` — must not print `NULL`.
+- **New fixture not picked up** — confirm the directory is directly under `tests/events/` (not nested two levels deep).

CALIBER_LEARNINGS.md

@@ -8,3 +8,9 @@ Auto-managed by [caliber](https://github.com/caliber-ai-org/ai-setup) — do not
 - **[gotcha:project]** `composer.json` has no `autoload`, `autoload-dev`, or `scripts` sections — there is no PSR-4 autoloader and no `composer test` shortcut. Classes (`GithubWebhook`, `IgnoredEventException`, etc.) are loaded via manual `require` statements. Tests must bootstrap these manually or via a PHPUnit bootstrap file.
 - **[pattern:project]** Real GitHub webhook payloads live in `log/` as JSON files with structure `{"repo": "...", "event": "...", "data": {...payload...}}`. The `data` key holds the raw webhook payload — use these as authoritative source material when creating new fixtures under `tests/events/`.
 - **[gotcha:project]** In the `push` event handler, `$Msg['alias']` is set from `$Message['head_commit']['author']['name']` (commit author name), **not** `$Message['pusher']['name']`. These differ when CI or bots push commits authored by a human. Code that compares commit authors against the pusher must use `$Msg['alias']`, not `$Message['pusher']['name']`.
+- **[fix:project]** `phpunit.xml` must have `bootstrap="tests/bootstrap.php"` set — without it PHPUnit cannot load source classes since there is no PSR-4 autoloader. The bootstrap file manually `require`s all `src/` classes.
+- **[gotcha:project]** `composer.json` now has a `scripts` section — `composer test`, `composer analyse`, `composer cs-fix`, and `composer cs-check` all work. The old stale learning about no scripts is now superseded.
+- **[convention:project]** Test fixture directories under `tests/events/{event_name}/` now use **3 files**: `payload.json`, `type.txt`, and `expected_text.txt` (plain text, no IRC color codes). The old 4-file format with `expected.bin` and `discord.json` was for the removed `IrcConverter`/`DiscordConverter` — do NOT create those files.
+- **[pattern:project]** `GithubMessageBuilder` (in `src/GithubMessageBuilder.php`) handles all message formatting. The `switch ($EventType)` block in `web/github.php` is now routing-only: call `$Builder->build()` before the switch, then each case just decides whether to call `SendToChat` or skip it. Do NOT rebuild `$Msg` inside individual cases.
+- **[gotcha:project]** `release` edited events have a `changes` key in the payload that is an **empty array** `[]` — GitHub does not populate what fields changed. There is no `from`/`to` data available for release edits; the message can only show the current release state, not what was modified.
+- **[gotcha:project]** `status` events (CI status from AppVeyor, Scrutinizer, Travis, etc.) are NOT ignored in the current codebase — they fall through to `default:` which emits a generic "triggered a status event" message. The payload has rich fields: `state` (success/failure/error/pending), `description` (CI message), `context` (CI service name), `target_url` (link to build), and `commit.commit.message`. Add a dedicated `case 'status':` handler in `GithubMessageBuilder::buildText()` to surface these fields.

CLAUDE.md

@@ -19,7 +19,7 @@ vendor/bin/php-cs-fixer fix
 - **Config**: `src/config.php` (gitignored) — defines `GITHUB_WEBHOOKS_SECRET` and `$chatChannels['rocketchat']` / `$chatChannels['teams']`
 - **Logs**: `log/` — JSON files named `Ymd_His_eventtype_action_user_repo.json`
 - **Tests**: `tests/` via `phpunit.xml` · fixtures in `tests/events/{event_name}/`
-- **Quality**: `phpstan.neon` · `.php-cs-fixer.dist.php` (PSR2 + PHP74Migration)
+- **Quality**: `phpstan.neon` · `phpstan-bootstrap.php` · `.php-cs-fixer.dist.php` (PSR2 + PHP74Migration)
 - **CI**: `.github/` — GitHub Actions workflows (`.github/workflows/ci.yml`)
 
 ## Event Handling Pattern
@@ -36,7 +36,7 @@ file_put_contents(__DIR__.'/../log/'.date('Ymd_His').'_'.$EventType
     .(isset($Message['action']) ? '_'.$Message['action'] : '')
     .'_'.$User.'_'.str_replace(['/', '-', ' '], '_', $RepositoryName).'.json',
     json_encode($log, JSON_PRETTY_PRINT | JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES));
-// 3. Route by event type
+// 3. Route by event type — $Builder->build() called before switch
 switch ($EventType) {
     case 'push': /* ... */ SendToChat('notifications', $Msg, $useRC, $useTeams); break;
     default: SendToChat('notifications', $Msg, $useRC, $useTeams); break;

phpstan-bootstrap.php

@@ -0,0 +1,7 @@
+<?php
+declare(strict_types=1);
+
+// Stub constants defined in gitignored src/config.php so PHPStan can analyse without it.
+if (!defined('GITHUB_WEBHOOKS_SECRET')) {
+    define('GITHUB_WEBHOOKS_SECRET', '');
+}

phpstan.neon

@@ -1,12 +1,11 @@
 parameters:
 	checkMissingIterableValueType: false
 	level: 6
+	bootstrapFiles:
+		- phpstan-bootstrap.php
 	paths:
 		- .
 	excludes_analyse:
 		- vendor
 		- examples
 		- public
-	ignoreErrors:
-		- message: "/Access to an undefined property object::.*/"
-		  path: src/*.php

web/github-old.php

@@ -17,7 +17,7 @@
 require __DIR__ . '/../src/IgnoredEventException.php';
 require __DIR__ . '/../src/NotImplementedException.php';
 
-$Hook = new GitHubWebHook();
+$Hook = new GithubWebhook();
 try {
     if (!$Hook->ValidateHubSignature(GITHUB_WEBHOOKS_SECRET)) {
         throw new Exception('Secret validation failed.');

web/github.php

@@ -17,7 +17,7 @@
 require __DIR__ . '/../src/IgnoredEventException.php';
 require __DIR__ . '/../src/NotImplementedException.php';
 
-$Hook = new GitHubWebHook();
+$Hook = new GithubWebhook();
 try {
     if (!$Hook->ValidateHubSignature(GITHUB_WEBHOOKS_SECRET)) {
         throw new Exception('Secret validation failed.');
@@ -267,6 +267,35 @@
             SendToChat('notifications', $Msg, $useRC, $useTeams);
             break;
 
+        case 'status':
+            $CiState = $Message['state'] ?? 'unknown';
+            $CiContext = $Message['context'] ?? 'CI';
+            $CiDescription = $Message['description'] ?? '';
+            $CiUrl = $Message['target_url'] ?? '';
+            $CommitUrl = $Message['commit']['html_url'] ?? '';
+            $CommitSha = substr($Message['sha'] ?? '', 0, 7);
+            $CommitMsg = $Message['commit']['commit']['message'] ?? '';
+            $CommitMsg = strtok($CommitMsg, "\n");
+            $StateEmoji = match ($CiState) {
+                'success' => '✅',
+                'failure' => '❌',
+                'error'   => '🚨',
+                'pending' => '⏳',
+                default   => 'ℹ️',
+            };
+            $CiLink = $CiUrl ? "[{$CiContext}]({$CiUrl})" : "**{$CiContext}**";
+            $CommitLink = $CommitUrl ? "[`{$CommitSha}`]({$CommitUrl})" : "`{$CommitSha}`";
+            $ChatMsg = "{$StateEmoji} **{$CiState}** — {$CiLink} on [{$RepositoryName}](https://github.com/{$RepositoryName}) {$CommitLink}";
+            if ($CiDescription !== '') {
+                $ChatMsg .= "\n> {$CiDescription}";
+            }
+            if ($CommitMsg !== '') {
+                $ChatMsg .= "\n> _{$CommitMsg}_";
+            }
+            $Msg['text'] = $ChatMsg;
+            SendToChat('notifications', $Msg, $useRC, $useTeams);
+            break;
+
         default:
             $ChatMsg = "ℹ️ {$Msg['alias']} triggered a **{$EventType}** event "
                      . (isset($Message['action']) ? "({$Message['action']}) " : "")
@@ -314,6 +343,7 @@ function SendToChat(string $Where, array $Payload, bool $useRC = true, bool $use
 {
     error_log("Sending Payload ".json_encode($Payload)." to {$Where}");
     global $chatChannels;
+    $Code = 0;
     if ($useRC === true) {
         $Url = $chatChannels['rocketchat'][$Where];
         $c = curl_init();