Skip to content

Commit e19d3a7

Browse files
committed
refact: post review changes
1 parent e29456c commit e19d3a7

1 file changed

Lines changed: 2 additions & 7 deletions

File tree

isolate/initialdispatch.go

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -63,15 +63,15 @@ func readStringsSlice(r *msgp.Reader) (uuids []string, err error) {
6363

6464
sz, err = r.ReadArrayHeader()
6565
if err != nil {
66-
return uuids, err
66+
return
6767
}
6868

6969
for i := uint32(0); i < sz; i++ {
7070
var u string
7171
if u, err = r.ReadString(); err == nil {
7272
uuids = append(uuids, u)
7373
} else {
74-
return uuids, err
74+
return
7575
}
7676
}
7777

@@ -326,11 +326,6 @@ func (d *initialDispatch) onWorkersMetrics(uuidsQuery []string) (Dispatcher, err
326326
err error
327327
)
328328

329-
if d == nil {
330-
log.G(d.ctx).Error("strange: dispatch is `nil`")
331-
return
332-
}
333-
334329
if err = msgp.Encode(&buf, &metrics); err != nil {
335330
log.G(d.ctx).WithError(err).Errorf("unable to encode containers metrics response: %v", err)
336331
d.stream.Error(d.ctx, replyMetricsError, errMarshallingError, err.Error())

0 commit comments

Comments
 (0)