Skip to content

Commit d491ac9

Browse files
VedranZoricicclaude
andcommitted
Address PR review findings
- Replace <uuid> placeholder with actual UUID format in error template to prevent literal output - Make version-propagation note future-proof by removing hardcoded v2.15 reference and adding "check the actual file" guidance - Consolidate CLAUDE.md skill directive into single paragraph Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent da4b983 commit d491ac9

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

.claude/skills/generate-openapi-from-pr/ruby-to-openapi-mapping.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,7 @@ Maps to:
404404
Resource not found:
405405
value:
406406
type: error.list
407-
request_id: <uuid>
407+
request_id: a1b2c3d4-e5f6-7890-abcd-ef1234567890
408408
errors:
409409
- code: not_found
410410
message: Resource Not Found

.claude/skills/generate-openapi-from-pr/version-propagation.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ intercom_version:
7777
- '2.14'
7878
```
7979
80-
Note: The v2.15 spec has `default: '2.14'` and does NOT include `'2.15'` in its own enum. This is an existing pattern — follow it.
80+
Note: Stable specs set `default` to the previous stable version and do NOT include their own version number in the enum. For example, v2.15 has `default: '2.14'` and does not list `'2.15'`. Always check the actual file to confirm the pattern before editing — it may evolve with future releases.
8181

8282
### info.version
8383

CLAUDE.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,7 @@ fern generate --group ts-sdk
124124

125125
## Skills
126126

127-
- **generate-openapi-from-pr** — Takes an intercom monolith PR and generates OpenAPI spec changes. Provide a PR URL/number from `intercom/intercom` and the skill analyzes the diff (controllers, presenters, version changes, routes) to produce the corresponding YAML updates in the target spec file(s). See `.claude/skills/generate-openapi-from-pr/SKILL.md`.
128-
129-
When a user provides an `intercom/intercom` PR URL or asks to generate OpenAPI docs from a PR, always use the `generate-openapi-from-pr` skill. Invoke it with: `/generate-openapi-from-pr <pr-url>`
127+
- **generate-openapi-from-pr** — Takes an intercom monolith PR and generates OpenAPI spec changes. Provide a PR URL/number from `intercom/intercom` and the skill analyzes the diff (controllers, presenters, version changes, routes) to produce the corresponding YAML updates in the target spec file(s). See `.claude/skills/generate-openapi-from-pr/SKILL.md`. This is the primary workflow for this repo — always use it when a user provides an intercom PR URL or asks to update the spec from a PR.
130128

131129
## Downstream Consumers
132130

0 commit comments

Comments
 (0)